Remove CustomizableSelectListbox flag [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Apr 1, 2026, 11:01:34 AM (19 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar

David Baron voted and added 1 comment

Votes added by David Baron

Code-Review+1

1 comment

Commit Message
Line 9, Patchset 2 (Latest):This has been enabled for 3 milestones, so it is safe to remove now.
David Baron . unresolved

Maybe add `(since M145)`?

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I962bae49da021b11f18568c7ec7552cf70baad4b
Gerrit-Change-Number: 7684220
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 15:01:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Apr 1, 2026, 3:52:56 PM (15 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org

Joey Arhar added 1 comment

Commit Message
Line 9, Patchset 2:This has been enabled for 3 milestones, so it is safe to remove now.
David Baron . resolved

Maybe add `(since M145)`?

Joey Arhar

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I962bae49da021b11f18568c7ec7552cf70baad4b
    Gerrit-Change-Number: 7684220
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 19:52:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Baron <dba...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joey Arhar (Gerrit)

    unread,
    Apr 1, 2026, 3:54:53 PM (15 hours ago) Apr 1
    to David Baron, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org

    Joey Arhar voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I962bae49da021b11f18568c7ec7552cf70baad4b
      Gerrit-Change-Number: 7684220
      Gerrit-PatchSet: 4
      Gerrit-Owner: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Comment-Date: Wed, 01 Apr 2026 19:54:44 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 1, 2026, 5:46:32 PM (13 hours ago) Apr 1
      to David Baron, AyeAye, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Remove CustomizableSelectListbox flag

      This has been enabled for 3 milestones (since M145), so it is safe to
      remove now.
      Bug: 357649033
      Change-Id: I962bae49da021b11f18568c7ec7552cf70baad4b
      Reviewed-by: David Baron <dba...@chromium.org>
      Commit-Queue: Joey Arhar <jar...@chromium.org>
      Reviewed-by: Joey Arhar <jar...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1608784}
      Files:
      • M third_party/blink/renderer/core/html/forms/html_opt_group_element.cc
      • M third_party/blink/renderer/core/html/forms/html_opt_group_element.h
      • M third_party/blink/renderer/core/html/forms/html_option_element.cc
      • M third_party/blink/renderer/core/html/forms/html_select_element.cc
      • M third_party/blink/renderer/core/html/resources/html.css
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/TestExpectations
      • M third_party/blink/web_tests/VirtualTestSuites
      • D third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/README.md
      • D third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/select-multiple-base-appearance-expected.html
      • D third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/select-multiple-base-appearance.html
      Change size: L
      Delta: 11 files changed, 130 insertions(+), 411 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Joey Arhar, +1 by David Baron
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I962bae49da021b11f18568c7ec7552cf70baad4b
      Gerrit-Change-Number: 7684220
      Gerrit-PatchSet: 5
      Gerrit-Owner: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages