Add more context for dates, plus better validation error message [chromium/src : main]
0 views
Skip to first unread message
Mason Freed (Gerrit)
4:13 PM (7 hours ago) 4:13 PM
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Mason Freed voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
4:34 PM (7 hours ago) 4:34 PM
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Anders Hartvoll Ruud . resolved
Shame that `"$comment"` didn't work. Especially if we _do_ want to spec how this input schema should look, I don't think we should mess with the `description` field long term---it's the author's "space".
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
4:36 PM (7 hours ago) 4:36 PM
to Adrian Lin, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Adrian Lin
Mason Freed added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Anders Hartvoll Ruud . resolved
Shame that `"$comment"` didn't work. Especially if we _do_ want to spec how this input schema should look, I don't think we should mess with the `description` field long term---it's the author's "space".
Mason Freed
+1. +adrian for comment on this. If we can get $comment un-filtered in the model input, I definitely agree with moving this to there.
Related details
Attention is currently required from:
- Adrian Lin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:06 PM (5 hours ago) 6:06 PM
to Mason Freed, Adrian Lin, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add more context for dates, plus better validation error message
It was previously common for dates to be passed in as 'MM/DD/YYYY' when
dates for HTML input elements must always be 'YYYY-MM-DD'. This CL adds
that bit of context to the description for date fields, and and also
adds a little more detail to the validation error message, so that the
agent might be able to correct errors more easily.
Change-Id: If46cee75b455b2d933b8c25e035ec6d47493d047
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Auto-Submit: Mason Freed <mas...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583553}
Files:
- M third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
- M third_party/blink/renderer/core/html/forms/form_mcp_schema.h
- M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
- M third_party/blink/renderer/core/script_tools/model_context_test.cc
Change size: S
Delta: 4 files changed, 27 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages