Make an SVGReferencedSymbolElement for <use>-instantiations [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Oct 16, 2025, 2:43:19 AM (3 days ago) Oct 16
to Rune Lillesveen, Fredrik Söderquist, Philip Rogers, Chromium LUCI CQ, AyeAye, Alexis Menard, David Bokan, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist and Philip Rogers

Rune Lillesveen added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rune Lillesveen . resolved

Is this an acceptable way of cloning <symbol> into <use> trees?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29ff1c6b98ac54ec728ba28b6c66621913c85a5a
Gerrit-Change-Number: 7044767
Gerrit-PatchSet: 3
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 06:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Oct 17, 2025, 7:34:16 AM (2 days ago) Oct 17
to Rune Lillesveen, Philip Rogers, Chromium LUCI CQ, AyeAye, Alexis Menard, David Bokan, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Philip Rogers and Rune Lillesveen

Fredrik Söderquist added 1 comment

Patchset-level comments
Rune Lillesveen . resolved

Is this an acceptable way of cloning <symbol> into <use> trees?

Fredrik Söderquist

I can't say that I'm a fan of "magic casting". Could we consider a structure where the relevant bits of `SVGSVGElement` is moved to a base-class where we can share it between `<svg>` and `<symbol>` instead?

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Rune Lillesveen
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Oct 2025 11:34:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Oct 17, 2025, 10:20:13 AM (2 days ago) Oct 17
to Rune Lillesveen, Fredrik Söderquist, Philip Rogers, Chromium LUCI CQ, AyeAye, Alexis Menard, David Bokan, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist and Philip Rogers

Rune Lillesveen added 1 comment

Patchset-level comments
Rune Lillesveen . unresolved

Is this an acceptable way of cloning <symbol> into <use> trees?

Fredrik Söderquist

I can't say that I'm a fan of "magic casting". Could we consider a structure where the relevant bits of `SVGSVGElement` is moved to a base-class where we can share it between `<svg>` and `<symbol>` instead?

Rune Lillesveen

I'll try that.

Thought the SVGGraphicsElement inheritance would be a problem, but according to the SVG2 spec, SVGSymbolElement should inherit from it too (we don't in our current impl).

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Fri, 17 Oct 2025 14:19:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
    Comment-In-Reply-To: Fredrik Söderquist <f...@opera.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages