HTMLSelectElement: prevent autofill from picking a non-existing option [chromium/src : main]

0 views
Skip to first unread message

Christoph Schwering (Gerrit)

unread,
Jul 31, 2026, 9:26:30 AM (17 hours ago) Jul 31
to Yoav Weiss (@Shopify), Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
Attention needed from Joey Arhar and Yoav Weiss (@Shopify)

Christoph Schwering voted and added 2 comments

Votes added by Christoph Schwering

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Christoph Schwering . resolved

LGTM, thanks!

File components/autofill/content/renderer/form_autofill_util_browsertest.cc
Line 6460, Patchset 1 (Latest): u"window.origOptions.find((o) => o.value === 'CA').selected"
Christoph Schwering . unresolved

nitty nit: use raw string literal `uR"(...)"`?

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
Gerrit-Change-Number: 8181846
Gerrit-PatchSet: 1
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 13:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Jul 31, 2026, 9:59:58 AM (17 hours ago) Jul 31
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
Attention needed from Joey Arhar

Yoav Weiss (@Shopify) added 1 comment

File components/autofill/content/renderer/form_autofill_util_browsertest.cc
Line 6460, Patchset 1: u"window.origOptions.find((o) => o.value === 'CA').selected"
Christoph Schwering . resolved

nitty nit: use raw string literal `uR"(...)"`?

Yoav Weiss (@Shopify)

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
    Gerrit-Change-Number: 8181846
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Jul 2026 13:59:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Christoph Schwering <schw...@google.com>
    satisfied_requirement
    open
    diffy

    Yoav Weiss (@Shopify) (Gerrit)

    unread,
    Jul 31, 2026, 10:00:25 AM (17 hours ago) Jul 31
    to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
    Attention needed from Joey Arhar

    Yoav Weiss (@Shopify) voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Fri, 31 Jul 2026 14:00:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joey Arhar (Gerrit)

    unread,
    Jul 31, 2026, 10:53:38 AM (16 hours ago) Jul 31
    to Yoav Weiss (@Shopify), Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
    Attention needed from Yoav Weiss (@Shopify)

    Joey Arhar voted and added 1 comment

    Votes added by Joey Arhar

    Code-Review+1

    1 comment

    File third_party/blink/renderer/core/html/forms/html_selected_content_element.cc
    File-level comment, Patchset 2 (Latest):
    Joey Arhar . unresolved

    are these changes tested?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yoav Weiss (@Shopify)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
      Gerrit-Change-Number: 8181846
      Gerrit-PatchSet: 2
      Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Jul 2026 14:53:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Joey Arhar (Gerrit)

      unread,
      Jul 31, 2026, 10:54:21 AM (16 hours ago) Jul 31
      to Yoav Weiss (@Shopify), Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
      Attention needed from Yoav Weiss (@Shopify)

      Joey Arhar added 1 comment

      Commit Message
      Line 9, Patchset 2 (Latest):Bug: 535975677
      Joey Arhar . unresolved

      do you want to mark this as fixed?

      Gerrit-Comment-Date: Fri, 31 Jul 2026 14:54:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yoav Weiss (@Shopify) (Gerrit)

      unread,
      Jul 31, 2026, 11:12:27 AM (15 hours ago) Jul 31
      to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
      Attention needed from Christoph Schwering, Joey Arhar and Yoav Weiss (@Shopify)

      Yoav Weiss (@Shopify) voted and added 2 comments

      Votes added by Yoav Weiss (@Shopify)

      Commit-Queue+1

      2 comments

      Commit Message
      Line 9, Patchset 2:Bug: 535975677
      Joey Arhar . resolved

      do you want to mark this as fixed?

      Yoav Weiss (@Shopify)

      Once this lands, yeah

      File third_party/blink/renderer/core/html/forms/html_selected_content_element.cc
      File-level comment, Patchset 2:
      Joey Arhar . resolved

      are these changes tested?

      Yoav Weiss (@Shopify)

      Good catch! Added one 😊

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christoph Schwering
      • Joey Arhar
      • Yoav Weiss (@Shopify)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
        Gerrit-Change-Number: 8181846
        Gerrit-PatchSet: 3
        Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
        Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Joey Arhar <jar...@chromium.org>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Christoph Schwering <schw...@google.com>
        Gerrit-Comment-Date: Fri, 31 Jul 2026 15:12:10 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Joey Arhar (Gerrit)

        unread,
        Jul 31, 2026, 11:35:35 AM (15 hours ago) Jul 31
        to Yoav Weiss (@Shopify), Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
        Attention needed from Christoph Schwering and Yoav Weiss (@Shopify)

        Joey Arhar voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Christoph Schwering
        • Yoav Weiss (@Shopify)
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
          Gerrit-Change-Number: 8181846
          Gerrit-PatchSet: 3
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Attention: Christoph Schwering <schw...@google.com>
          Gerrit-Comment-Date: Fri, 31 Jul 2026 15:35:20 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Yoav Weiss (@Shopify) (Gerrit)

          unread,
          Jul 31, 2026, 11:46:27 AM (15 hours ago) Jul 31
          to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org
          Attention needed from Christoph Schwering

          Yoav Weiss (@Shopify) voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Christoph Schwering
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
          Gerrit-Change-Number: 8181846
          Gerrit-PatchSet: 3
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Attention: Christoph Schwering <schw...@google.com>
          Gerrit-Comment-Date: Fri, 31 Jul 2026 15:46:09 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jul 31, 2026, 12:20:03 PM (14 hours ago) Jul 31
          to Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          HTMLSelectElement: prevent autofill from picking a non-existing option
          Bug: 535975677
          Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
          Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Reviewed-by: Joey Arhar <jar...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1671902}
          Files:
          • M components/autofill/content/renderer/form_autofill_util_browsertest.cc
          • M third_party/blink/renderer/core/exported/web_select_element.cc
          • M third_party/blink/renderer/core/html/forms/html_select_element.cc
          • M third_party/blink/renderer/core/html/forms/html_select_element_test.cc
          • M third_party/blink/renderer/core/html/forms/html_selected_content_element.cc
          • M third_party/blink/renderer/core/html/forms/html_selected_content_element.h
          Change size: M
          Delta: 6 files changed, 194 insertions(+), 3 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Joey Arhar
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I381cff67ba6b4d6da0aba10b284fe82b754d9511
          Gerrit-Change-Number: 8181846
          Gerrit-PatchSet: 4
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages