[a11y] Clean up a deprecated flag: kTextBasedAudioDescriptionName. [chromium/src : main]

0 views
Skip to first unread message

Philip Jägenstedt (Gerrit)

unread,
Apr 20, 2026, 11:47:22 AM (2 days ago) Apr 20
to Gregory Dardyk, Evan Liu, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
Attention needed from Evan Liu and Gregory Dardyk

Philip Jägenstedt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Evan Liu
  • Gregory Dardyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
Gerrit-Change-Number: 7765536
Gerrit-PatchSet: 9
Gerrit-Owner: Gregory Dardyk <greg...@google.com>
Gerrit-Reviewer: Evan Liu <ev...@google.com>
Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Evan Liu <ev...@google.com>
Gerrit-Attention: Gregory Dardyk <greg...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 15:46:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ramin Halavati (Gerrit)

unread,
Apr 20, 2026, 12:54:50 PM (2 days ago) Apr 20
to Gregory Dardyk, Ramin Halavati, Philip Jägenstedt, Evan Liu, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
Attention needed from Evan Liu and Gregory Dardyk

Ramin Halavati voted and added 3 comments

Votes added by Ramin Halavati

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Ramin Halavati . resolved

LGTM % nits

File third_party/blink/renderer/modules/speech/speech_synthesis.cc
Line 101, Patchset 9 (Latest):bool SpeechSynthesis::speaking() const {
Ramin Halavati . unresolved

nit: Style guide suggests Pascal Case [1], so instead of this one, the others need updating.


[1]https://google.github.io/styleguide/cppguide.html#Function_Names

Line 146, Patchset 9 (Latest):void SpeechSynthesis::cancel() {
Ramin Halavati . unresolved

These changes are in the reverse direction of the style guide:
https://google.github.io/styleguide/cppguide.html#Function_Names

Open in Gerrit

Related details

Attention is currently required from:
  • Evan Liu
  • Gregory Dardyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
Gerrit-Change-Number: 7765536
Gerrit-PatchSet: 9
Gerrit-Owner: Gregory Dardyk <greg...@google.com>
Gerrit-Reviewer: Evan Liu <ev...@google.com>
Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Evan Liu <ev...@google.com>
Gerrit-Attention: Gregory Dardyk <greg...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 16:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gregory Dardyk (Gerrit)

unread,
Apr 20, 2026, 1:13:59 PM (2 days ago) Apr 20
to Ramin Halavati, Philip Jägenstedt, Evan Liu, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
Attention needed from Evan Liu

Gregory Dardyk added 2 comments

File third_party/blink/renderer/modules/speech/speech_synthesis.cc
Line 101, Patchset 9 (Latest):bool SpeechSynthesis::speaking() const {
Ramin Halavati . resolved

nit: Style guide suggests Pascal Case [1], so instead of this one, the others need updating.


[1]https://google.github.io/styleguide/cppguide.html#Function_Names

Gregory Dardyk

The Blink C++ guide says web-exposed bindings are an exception: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/blink-c++.md#naming

As far as I understand, the functions we are changing here are part of that exception: https://webaudio.github.io/web-speech-api/#tts-methods

Line 146, Patchset 9 (Latest):void SpeechSynthesis::cancel() {
Ramin Halavati . resolved

These changes are in the reverse direction of the style guide:
https://google.github.io/styleguide/cppguide.html#Function_Names

Gregory Dardyk

see above.

Open in Gerrit

Related details

Attention is currently required from:
  • Evan Liu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
    Gerrit-Change-Number: 7765536
    Gerrit-PatchSet: 9
    Gerrit-Owner: Gregory Dardyk <greg...@google.com>
    Gerrit-Reviewer: Evan Liu <ev...@google.com>
    Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Evan Liu <ev...@google.com>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 17:13:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ramin Halavati <rhal...@chromium.org>
    satisfied_requirement
    open
    diffy

    Evan Liu (Gerrit)

    unread,
    Apr 20, 2026, 1:19:37 PM (2 days ago) Apr 20
    to Gregory Dardyk, Ramin Halavati, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
    Attention needed from Gregory Dardyk

    Evan Liu voted and added 1 comment

    Votes added by Evan Liu

    Code-Review+1

    1 comment

    Commit Message
    Line 7, Patchset 9 (Latest):[a11y] Clean up a deprecated flag: kTextBasedAudioDescriptionName.
    Evan Liu . resolved

    It's a shame this never ended up shipping 😢

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gregory Dardyk
    Gerrit-Attention: Gregory Dardyk <greg...@google.com>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 17:19:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gregory Dardyk (Gerrit)

    unread,
    Apr 21, 2026, 12:58:15 PM (19 hours ago) Apr 21
    to Evan Liu, Ramin Halavati, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
    Attention needed from Evan Liu, Philip Jägenstedt and Ramin Halavati

    Gregory Dardyk added 1 comment

    Patchset-level comments
    File-level comment, Patchset 11 (Latest):
    Gregory Dardyk . resolved

    Unfortunately the votes were outdated after I synced, can you please re-approve?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Evan Liu
    • Philip Jägenstedt
    • Ramin Halavati
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
      Gerrit-Change-Number: 7765536
      Gerrit-PatchSet: 11
      Gerrit-Owner: Gregory Dardyk <greg...@google.com>
      Gerrit-Reviewer: Evan Liu <ev...@google.com>
      Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Attention: Evan Liu <ev...@google.com>
      Gerrit-Attention: Ramin Halavati <rhal...@chromium.org>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 16:58:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ramin Halavati (Gerrit)

      unread,
      Apr 21, 2026, 1:07:38 PM (19 hours ago) Apr 21
      to Gregory Dardyk, Ramin Halavati, Evan Liu, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
      Attention needed from Evan Liu, Gregory Dardyk and Philip Jägenstedt

      Ramin Halavati voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Evan Liu
      • Gregory Dardyk
      • Philip Jägenstedt
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
        Gerrit-Change-Number: 7765536
        Gerrit-PatchSet: 11
        Gerrit-Owner: Gregory Dardyk <greg...@google.com>
        Gerrit-Reviewer: Evan Liu <ev...@google.com>
        Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
        Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
        Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Fredrik Söderquist <f...@opera.com>
        Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
        Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
        Gerrit-Attention: Evan Liu <ev...@google.com>
        Gerrit-Attention: Gregory Dardyk <greg...@google.com>
        Gerrit-Comment-Date: Tue, 21 Apr 2026 17:07:16 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Evan Liu (Gerrit)

        unread,
        Apr 21, 2026, 1:11:53 PM (19 hours ago) Apr 21
        to Gregory Dardyk, Ramin Halavati, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
        Attention needed from Gregory Dardyk and Philip Jägenstedt

        Evan Liu voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Gregory Dardyk
        • Philip Jägenstedt
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
          Gerrit-Change-Number: 7765536
          Gerrit-PatchSet: 11
          Gerrit-Owner: Gregory Dardyk <greg...@google.com>
          Gerrit-Reviewer: Evan Liu <ev...@google.com>
          Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
          Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Fredrik Söderquist <f...@opera.com>
          Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
          Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-Attention: Gregory Dardyk <greg...@google.com>
          Gerrit-Comment-Date: Tue, 21 Apr 2026 17:11:45 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Gregory Dardyk (Gerrit)

          unread,
          Apr 21, 2026, 3:10:57 PM (17 hours ago) Apr 21
          to Evan Liu, Ramin Halavati, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org
          Attention needed from Philip Jägenstedt

          Gregory Dardyk voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Philip Jägenstedt
          Gerrit-Comment-Date: Tue, 21 Apr 2026 19:10:46 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Apr 21, 2026, 3:14:50 PM (17 hours ago) Apr 21
          to Gregory Dardyk, Evan Liu, Ramin Halavati, Philip Jägenstedt, Chromium Metrics Reviews, (Julie)Jeongeun Kim, srirama chandra sekhar, Akihiro Ota, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-re...@chromium.org, asvitki...@chromium.org, kyungjunle...@google.com, josiah...@chromium.org, francisjp...@google.com, eric.c...@apple.com, blink-...@chromium.org, feature-me...@chromium.org, silv...@chromium.org, dtseng...@chromium.org, abigailbk...@google.com, blink-rev...@chromium.org, gl...@chromium.org, yuzo+...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          [a11y] Clean up a deprecated flag: kTextBasedAudioDescriptionName.

          Bug: 504595261
          Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709
          Reviewed-by: Evan Liu <ev...@google.com>
          Reviewed-by: Ramin Halavati <rhal...@chromium.org>
          Commit-Queue: Gregory Dardyk <greg...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1618363}
          Files:
          • M chrome/browser/about_flags.cc
          • M chrome/browser/flag-metadata.json
          • M chrome/browser/flag_descriptions.h
          • M third_party/blink/public/platform/web_media_player.h
          • M third_party/blink/renderer/core/BUILD.gn
          • M third_party/blink/renderer/core/html/media/html_media_element.cc
          • M third_party/blink/renderer/core/html/media/html_media_element.h
          • M third_party/blink/renderer/core/html/track/cue_timeline.cc
          • M third_party/blink/renderer/core/html/track/text_track.cc
          • M third_party/blink/renderer/core/html/track/text_track.h
          • M third_party/blink/renderer/core/html/track/text_track_container.cc
          • M third_party/blink/renderer/core/html/track/text_track_cue.h
          • M third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
          • M third_party/blink/renderer/core/html/track/vtt/vtt_cue.h
          • D third_party/blink/renderer/core/speech/build.gni
          • D third_party/blink/renderer/core/speech/speech_synthesis_base.cc
          • D third_party/blink/renderer/core/speech/speech_synthesis_base.h
          • M third_party/blink/renderer/modules/modules_initializer.cc
          • M third_party/blink/renderer/modules/speech/speech_synthesis.cc
          • M third_party/blink/renderer/modules/speech/speech_synthesis.h
          • M tools/metrics/histograms/enums.xml
          • M ui/accessibility/accessibility_features.cc
          • M ui/accessibility/accessibility_features.h
          Change size: L
          Delta: 23 files changed, 11 insertions(+), 297 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Ramin Halavati, +1 by Evan Liu
           Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          


           Gerrit-MessageType: merged 
          

           Gerrit-Project: chromium/src 
          

           Gerrit-Branch: main 
          

           Gerrit-Change-Id: I87ef3ada8f64ba1a979932586e80c916a4b0c709 
          

           Gerrit-Change-Number: 7765536 
          

           Gerrit-PatchSet: 12 
          

           Gerrit-Owner: Gregory Dardyk <greg...@google.com> 
          

           Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
          

           Gerrit-Reviewer: Evan Liu <ev...@google.com> 
          

           Gerrit-Reviewer: Gregory Dardyk <greg...@google.com> 
          

           Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org> 
          

           Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org> 
          

           Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org> 
          

           Gerrit-CC: Akihiro Ota <akihi...@chromium.org> 
          

          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages