CanvasTextNG: Fix cache memory leak through texImage2D [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
Oct 17, 2025, 12:55:11 AM (3 days ago) Oct 17
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Oct 17, 2025, 2:35:01 AM (2 days ago) Oct 17
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 17, 2025, 2:37:44 AM (2 days ago) Oct 17
to Kent Tamura, Koji Ishii, chromium...@chromium.org, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CanvasTextNG: Fix cache memory leak through texImage2D
UniqueFontSelector allows to cache unlimited number of `Font` instances
if they are used in a single frame, however we failed to notify it of
frame changes if a canvas is used for `texImage2D()`.
This CL fixes the issue by calling `DidSwitchFrame()` in
`OffscreenCanvas::GetSourceImageForCanvas()`.
Bug: 450531794
Change-Id: I738ffa059e7ec737f03cc4c37004e95a2f111173
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531238}
Files:
- M third_party/blink/renderer/core/html/canvas/unique_font_selector.h
- M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
- M third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 4 files changed, 55 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sunny Sachanandani (Gerrit)
Oct 17, 2025, 11:10:45 AM (2 days ago) Oct 17
to Chromium LUCI CQ, Kent Tamura, Koji Ishii, chromium...@chromium.org, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Sunny Sachanandani added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
Line 285, Patchset 3 (Latest):
if (RuntimeEnabledFeatures::CanvasTextTexImage2DFixEnabled()) {
if (plain_text_painter_) {
plain_text_painter_->DidSwitchFrame();
}
if (unique_font_selector_) {
unique_font_selector_->DidSwitchFrame();
}
}Sunny Sachanandani . unresolved
We should put this in a new `OffscreenCanvas::FinalizeFrame` method which should be called for all the various code paths where an OffscreenCanvas is exported e.g. createImageBitmap, toBlob, transferToImageBitmap, etc. Maybe look for existing calls to `OffscreenCanvasRenderingContext2D::FinalizeFrame` and then replace those with `OffscreenCanvas::FinalizeFrame` which calls into `OffscreenCanvasRenderingContext2D::FinalizeFrame` in addition to doing this `DidSwitchFrame` stuff. WDYT?
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages