experiment to rust [chromium/src : main]

0 views
Skip to first unread message

AI Code Reviewer (Gerrit)

unread,
Dec 20, 2025, 5:04:48 AM (3 days ago) Dec 20
to Daniel Angulo, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

AI Code Reviewer added 2 comments

File third_party/blink/renderer/core/html/html_li_element.h
Line 46, Patchset 1 (Latest):void add_list_style_type(HeapVector<CSSPropertyValue, 8>&, int);
AI Code Reviewer . unresolved

Blink Style Guide: May leave obvious parameter names out of function declarations. Primitive types like 'int' are not considered obvious. Please add a parameter name (e.g., 'value_id').

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Line 43, Patchset 1 (Latest):bool base_is_presentation_attribute(HTMLLIElement*, const QualifiedName&);
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. Functions like 'base_is_presentation_attribute' should be 'BaseIsPresentationAttribute'. Note: getters should use bare words (e.g., 'AttributeName' instead of 'GetAttributeName').

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0271093eb14048170f2f883dd1a59ebfab1637da
Gerrit-Change-Number: 7287077
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Angulo <angd...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Comment-Date: Sat, 20 Dec 2025 10:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages