[wip] inline Element::GetShadowRoot() [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Dec 11, 2025, 4:46:33 AM (yesterday) Dec 11
to Raphael Kubo da Costa, Olga Gerchikov, David Bokan, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Menard, Alexis, Kentaro Hara, Kevin Babbitt, blink-re...@chromium.org, steimel+watch...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, francisjp...@google.com, josiah...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, feature-me...@chromium.org, yuzo+...@chromium.org, abigailbk...@google.com, dtapuska+...@chromium.org, kyungjunle...@google.com, dtseng...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] inline Element::GetShadowRoot()
Change-Id: I0454138621290d494bc01c1a752118b373f74735

Change diff


Change information

Files:
  • M third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
  • M third_party/blink/renderer/core/animation/css/css_animations.cc
  • M third_party/blink/renderer/core/css/check_pseudo_has_argument_context.cc
  • M third_party/blink/renderer/core/css/invalidation/style_invalidator.cc
  • M third_party/blink/renderer/core/css/resolver/style_resolver.cc
  • M third_party/blink/renderer/core/css/selector_checker.cc
  • M third_party/blink/renderer/core/css/style_engine.cc
  • M third_party/blink/renderer/core/css/style_engine_test.cc
  • M third_party/blink/renderer/core/css/style_recalc_root.cc
  • M third_party/blink/renderer/core/display_lock/display_lock_context_test.cc
  • M third_party/blink/renderer/core/dom/child_frame_disconnector.cc
  • M third_party/blink/renderer/core/dom/container_node.cc
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/dom/element.cc
  • M third_party/blink/renderer/core/dom/element.h
  • M third_party/blink/renderer/core/dom/flat_tree_traversal.cc
  • M third_party/blink/renderer/core/dom/node.cc
  • M third_party/blink/renderer/core/dom/shadow_including_tree_order_traversal.h
  • A third_party/blink/renderer/core/dom/shadow_root-inl.h
  • M third_party/blink/renderer/core/dom/shadow_root.h
  • M third_party/blink/renderer/core/dom/tree_scope.cc
  • M third_party/blink/renderer/core/dom/tree_scope_adopter.cc
  • M third_party/blink/renderer/core/dom/visited_link_state.cc
  • M third_party/blink/renderer/core/editing/selection_adjuster.cc
  • M third_party/blink/renderer/core/editing/selection_editor.cc
  • M third_party/blink/renderer/core/editing/serializers/markup_accumulator.cc
  • M third_party/blink/renderer/core/editing/serializers/styled_markup_serializer.cc
  • M third_party/blink/renderer/core/editing/text_offset_mapping.cc
  • M third_party/blink/renderer/core/editing/visible_units.cc
  • M third_party/blink/renderer/core/exported/web_element.cc
  • M third_party/blink/renderer/core/frame/frame_serializer.cc
  • M third_party/blink/renderer/core/frame/mhtml_loading_test.cc
  • M third_party/blink/renderer/core/html/custom/custom_element_registry.cc
  • M third_party/blink/renderer/core/html/forms/color_input_type.cc
  • M third_party/blink/renderer/core/html/forms/file_input_type.cc
  • M third_party/blink/renderer/core/html/forms/html_input_element_test.cc
  • M third_party/blink/renderer/core/html/forms/labels_node_list.cc
  • M third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
  • M third_party/blink/renderer/core/html/forms/range_input_type.cc
  • M third_party/blink/renderer/core/html/forms/text_field_input_type.cc
  • M third_party/blink/renderer/core/input/event_handler_test.cc
  • M third_party/blink/renderer/core/inspector/dom_traversal_utils.cc
  • M third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
  • M third_party/blink/renderer/core/inspector/inspector_dom_snapshot_agent.cc
  • M third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
  • M third_party/blink/renderer/core/page/focus_controller.cc
  • M third_party/blink/renderer/core/sanitizer/sanitizer.cc
  • M third_party/blink/renderer/core/testing/internals.cc
  • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_animated_arrow_container_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_scrubbing_message_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_slider_element.cc
  • M third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
Change size: M
Delta: 56 files changed, 145 insertions(+), 78 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0454138621290d494bc01c1a752118b373f74735
Gerrit-Change-Number: 7245602
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 11, 2025, 6:08:09 AM (yesterday) Dec 11
to Steinar H Gunderson, Menard, Alexis, David Bokan, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Alex Keng, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, steimel+watch...@chromium.org, yuzo+...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/165a42c8b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0454138621290d494bc01c1a752118b373f74735
Gerrit-Change-Number: 7245602
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 11:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
7:22 AM (13 hours ago) 7:22 AM
to chrom...@appspot.gserviceaccount.com, Menard, Alexis, David Bokan, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Alex Keng, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, steimel+watch...@chromium.org, yuzo+...@chromium.org

Steinar H Gunderson abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages