Avoid null lazy-load observation target during print [chromium/src : main]
0 views
Skip to first unread message
Iris Zhou (Gerrit)
Jul 28, 2026, 12:41:06 PM (4 days ago) Jul 28
to Piet Schouten, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Piet Schouten
Iris Zhou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Iris Zhou
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Iris Zhou . resolved
Hey PH, mind taking a quick look at this?
Related details
Attention is currently required from:
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piet Schouten (Gerrit)
Jul 28, 2026, 4:32:07 PM (3 days ago) Jul 28
to Iris Zhou, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Iris Zhou
Piet Schouten added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Piet Schouten . resolved
LGTM
File third_party/blink/renderer/core/html/media/lazy_load_media_observer.cc
Line 76, Patchset 2 (Latest):
// A tracked observation can outlive its weak target.Piet Schouten . unresolved
Not sure if it's needed, but should the comment here explain why the observation can outlive its target to make it easier for readers in the future?
Related details
Attention is currently required from:
- Iris Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Iris Zhou (Gerrit)
Jul 28, 2026, 5:15:02 PM (3 days ago) Jul 28
to Dale Curtis, Mason Freed, Chromium LUCI CQ, Piet Schouten, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis, Mason Freed and Piet Schouten
Iris Zhou added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Iris Zhou . resolved
Adding owners for the two files changed in this CL. This is a sort of follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/7819221 - we continued to get some similar crashes in Edge even after that fix went in, so I re-investigated and made this change. Please take a look when you have the chance, thanks!
File third_party/blink/renderer/core/html/media/lazy_load_media_observer.cc
Not sure if it's needed, but should the comment here explain why the observation can outlive its target to make it easier for readers in the future?
Attention is currently required from:
- Dale Curtis
- Mason Freed
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jul 28, 2026, 5:34:03 PM (3 days ago) Jul 28
to Iris Zhou, Mason Freed, Chromium LUCI CQ, Piet Schouten, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Iris Zhou, Mason Freed and Piet Schouten
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Iris Zhou
- Mason Freed
- Piet Schouten
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piet Schouten (Gerrit)
Jul 28, 2026, 6:38:32 PM (3 days ago) Jul 28
to Iris Zhou, Dale Curtis, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Iris Zhou and Mason Freed
Piet Schouten voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Iris Zhou
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jul 29, 2026, 8:28:26 PM (2 days ago) Jul 29
to Iris Zhou, Piet Schouten, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Iris Zhou
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Iris Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Iris Zhou (Gerrit)
Jul 30, 2026, 12:32:32 PM (2 days ago) Jul 30
to Mason Freed, Piet Schouten, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Iris Zhou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 30, 2026, 1:27:06 PM (2 days ago) Jul 30
to Iris Zhou, Mason Freed, Piet Schouten, Dale Curtis, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid null lazy-load observation target during print
LazyLoadMediaObserver::LoadAllImagesAndBlockLoadEvent() assumes each
IntersectionObservation has a live target while loading deferred images
for print.
IntersectionObservation stores its target weakly. If the target is
collected while its observation remains reachable, the print path
dereferences the null target through Element::GetDocument(). Skip
observations whose targets are no longer live.
Add a regression test for a collected target retained by an observation.
Bug: 539765586
Change-Id: I8f10ce1d6c9627443981400e838f6aa685e8ccc4
Reviewed-by: Piet Schouten <Piet.S...@microsoft.com>
Commit-Queue: Iris Zhou <irz...@microsoft.com>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671198}
Files:
- M third_party/blink/renderer/core/html/lazy_load_image_observer_test.cc
- M third_party/blink/renderer/core/html/media/lazy_load_media_observer.cc
Change size: S
Delta: 2 files changed, 25 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Piet Schouten, +1 by Mason Freed, +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages