Use FoldCase for :filtered [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Mar 5, 2026, 2:45:21 PM (yesterday) Mar 5
to David Baron, Chromium LUCI CQ, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
David Baron voted and added 2 comments![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html
Line 85, Patchset 1 (Latest):
}, 'Customizable combobox option:filtered behavior');David Baron . unresolved
Could you add a few tests exercising some more simple unicode cases, for example: three finding THREE (reverse of above)
- Ç finding ç (and vice versa, both characters between 128 and 256)
- ÿ and Ÿ both ways (one is under 256, the other isn't)
- U+0187 Ƈ and U+0188 ƈ both ways (both 2 byte UTF-8 encoded)
- U+A726 Ꜧ and U+A727 ꜧ (both above 256 and 3-byte UTF-8 encoded)
- U+10400 and U+10428 (both outside of the BMP, 4-byte UTF-16 and 4-byte UTF-8)
(It's possible one or more of those is interesting in ways I didn't realize, but I *think* they're all straightforward.)
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Mar 5, 2026, 3:54:04 PM (yesterday) Mar 5
to David Baron, Chromium LUCI CQ, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html
Could you add a few tests exercising some more simple unicode cases, for example: three finding THREE (reverse of above)
- Ç finding ç (and vice versa, both characters between 128 and 256)
- ÿ and Ÿ both ways (one is under 256, the other isn't)
- U+0187 Ƈ and U+0188 ƈ both ways (both 2 byte UTF-8 encoded)
- U+A726 Ꜧ and U+A727 ꜧ (both above 256 and 3-byte UTF-8 encoded)
- U+10400 and U+10428 (both outside of the BMP, 4-byte UTF-16 and 4-byte UTF-8)
(It's possible one or more of those is interesting in ways I didn't realize, but I *think* they're all straightforward.)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Mar 5, 2026, 4:00:16 PM (yesterday) Mar 5
to David Baron, Chromium LUCI CQ, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58300.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Mar 5, 2026, 5:04:30 PM (yesterday) Mar 5
to Blink W3C Test Autoroller, David Baron, Chromium LUCI CQ, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html
Line 97, Patchset 2 (Latest):
David Baron . unresolved
Maybe it would be good to have a few more `checkOptions()` just to make sure that something *changes* somewhere during this test?
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
6:22 PM (5 hours ago) 6:22 PM
to Blink W3C Test Autoroller, David Baron, Chromium LUCI CQ, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html
Maybe it would be good to have a few more `checkOptions()` just to make sure that something *changes* somewhere during this test?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:52 PM (4 hours ago) 7:52 PM
to Blink W3C Test Autoroller, David Baron, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use FoldCase for :filtered
Typing to search through the options should not require case sensitive
matching.
Bug: 453705243
Change-Id: I3721ce138e07d9ff79d8efd5138ad5a57e023925
Reviewed-by: David Baron <dba...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1595807}
Files:
- M third_party/blink/renderer/core/html/forms/text_field_input_type.cc
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/filterable-select/filterable-select-filtered-pseudo.tentative.html
Change size: M
Delta: 3 files changed, 75 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Baron, +1 by Joey Arhar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages