Connect CSS pseudo classes to form filled state [5/N] [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Jan 23, 2026, 7:03:26 PMJan 23
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Anders Hartvoll Ruud

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
Gerrit-Change-Number: 7514805
Gerrit-PatchSet: 3
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Sat, 24 Jan 2026 00:03:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jan 26, 2026, 4:20:25 AMJan 26
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mason Freed

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review+1

1 comment

File third_party/blink/renderer/core/html/forms/html_form_element.cc
Line 235, Patchset 7 (Latest): for (ListedElement* element : form_->ListedElements()) {
if (auto* control = DynamicTo<HTMLFormControlElement>(element)) {
control->PseudoStateChanged(CSSSelector::kPseudoToolSubmitActive);
}
}
Anders Hartvoll Ruud . unresolved

Why not do that on `active_submit_button_` instead? (Before clearing it.)

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
    Gerrit-Change-Number: 7514805
    Gerrit-PatchSet: 7
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Mon, 26 Jan 2026 09:20:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    Jan 26, 2026, 6:11:06 PMJan 26
    to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org

    Mason Freed voted and added 1 comment

    Votes added by Mason Freed

    Auto-Submit+1

    1 comment

    File third_party/blink/renderer/core/html/forms/html_form_element.cc
    Line 235, Patchset 7: for (ListedElement* element : form_->ListedElements()) {

    if (auto* control = DynamicTo<HTMLFormControlElement>(element)) {
    control->PseudoStateChanged(CSSSelector::kPseudoToolSubmitActive);
    }
    }
    Anders Hartvoll Ruud . resolved

    Why not do that on `active_submit_button_` instead? (Before clearing it.)

    Mason Freed

    Yep, that'd be better. Done.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Gerrit-Change-Number: 7514805
      Gerrit-PatchSet: 10
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Mon, 26 Jan 2026 23:10:57 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mason Freed (Gerrit)

      unread,
      Jan 26, 2026, 6:12:32 PMJan 26
      to Ben Greenstein, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Ben Greenstein

      Mason Freed added 1 comment

      Patchset-level comments
      File-level comment, Patchset 10 (Latest):
      Mason Freed . resolved

      +bengr for script_tool_browsertest.cc

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Greenstein
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Gerrit-Change-Number: 7514805
      Gerrit-PatchSet: 10
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Ben Greenstein <be...@chromium.org>
      Gerrit-Comment-Date: Mon, 26 Jan 2026 23:12:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ben Greenstein (Gerrit)

      unread,
      Jan 26, 2026, 7:43:41 PMJan 26
      to Mason Freed, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Mason Freed

      Ben Greenstein voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mason Freed
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Gerrit-Change-Number: 7514805
      Gerrit-PatchSet: 10
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Tue, 27 Jan 2026 00:43:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Mason Freed (Gerrit)

      unread,
      Jan 27, 2026, 10:51:04 AMJan 27
      to Ben Greenstein, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Ben Greenstein

      Mason Freed voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Greenstein
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Gerrit-Change-Number: 7514805
      Gerrit-PatchSet: 10
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Ben Greenstein <be...@chromium.org>
      Gerrit-Comment-Date: Tue, 27 Jan 2026 15:50:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 27, 2026, 11:45:07 AMJan 27
      to Mason Freed, Ben Greenstein, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Connect CSS pseudo classes to form filled state [5/N]

      This connects the existing CSS pseudo classes to the actual agent-
      filled state. It also adds a test.

      The pseudo classes are:

      - `:tool-form-active` - matches the <form> element when it has been
        filled by the agent, and is waiting for submission.
      - `:tool-submit-active` - matches the submit button for the form, in
        this case.
      Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
      Auto-Submit: Mason Freed <mas...@chromium.org>
      Commit-Queue: Mason Freed <mas...@chromium.org>
      Reviewed-by: Ben Greenstein <be...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1575274}
      Files:
      • M chrome/browser/actor/tools/script_tool_browsertest.cc
      • M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
      • M third_party/blink/renderer/core/html/forms/html_form_control_element.h
      • M third_party/blink/renderer/core/html/forms/html_form_element.cc
      • M third_party/blink/renderer/core/html/forms/html_form_element.h
      • M third_party/blink/renderer/core/script_tools/model_context_test.cc
      Change size: M
      Delta: 6 files changed, 176 insertions(+), 63 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud, +1 by Ben Greenstein
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3868f2fc0c41dd14b6e14f74504a0de8af02f4f7
      Gerrit-Change-Number: 7514805
      Gerrit-PatchSet: 11
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages