Track iframe elements for Page Content Annotations. [chromium/src : main]

0 views

Skip to first unread message

Ryan Kalla (Gerrit)

unread,

Apr 20, 2026, 1:43:50 PM (2 days ago) Apr 20

to Philip Rogers, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-intell...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Philip Rogers

Ryan Kalla added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Ryan Kalla . resolved

Hey @p...@chromium.org. This is the approach I described [here](https://docs.google.com/document/d/1admTWDMlns478TvaScUqwllvNdVIAA_xNJy2L9aZE8A/edit?resourcekey=0-ZVHfoq3gmQREgYnnMSkptQ&disco=AAAB3YMP6Cc). I'm happy to discuss things here or in the doc.

Open in Gerrit

Related details

Attention is currently required from:

Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

AI Code Reviewer (Gerrit)

unread,

Apr 20, 2026, 1:44:44 PM (2 days ago) Apr 20

to Ryan Kalla, Philip Rogers, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-intell...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Philip Rogers

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/html/html_iframe_element.cc

Line 28, Patchset 3 (Latest):#include "components/page_content_annotations/core/page_content_annotations_features.h"

AI Code Reviewer . unresolved

Blink Style Guide: Dependencies. Code in `blink/renderer/core/` should not depend directly on `components/`. Dependencies must only flow downwards (e.g., to `platform/`, `public/`, `//base`, `V8`). Please inject this state via Blink's public API or handle the feature logic in the browser process.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ryan Kalla (Gerrit)

unread,

Apr 20, 2026, 1:57:46 PM (2 days ago) Apr 20

to AI Code Reviewer, Philip Rogers, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chrome-intell...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Philip Rogers

Ryan Kalla added 1 comment

File third_party/blink/renderer/core/html/html_iframe_element.cc

Line 28, Patchset 3 (Latest):#include "components/page_content_annotations/core/page_content_annotations_features.h"

AI Code Reviewer . resolved

Blink Style Guide: Dependencies. Code in `blink/renderer/core/` should not depend directly on `components/`. Dependencies must only flow downwards (e.g., to `platform/`, `public/`, `//base`, `V8`). Please inject this state via Blink's public API or handle the feature logic in the browser process.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Ryan Kalla

OK But Won't Fix: I'm not sure this is correct. I don't see this rule referenced anywhere in the [Blink C++ Style Guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/blink-c++.md) or the [Blink architecture overview](https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/README.md#Type-dependencies). I also see several examples importing `components/` into `blink/renderer/core/`.

Open in Gerrit

Related details

Attention is currently required from:

Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages