[CE] Add `oncancel` event to HTMLUserMediaElement. [chromium/src : main]
0 views
Skip to first unread message
Ravjit Uppal (Gerrit)
May 29, 2026, 10:57:34 AM (3 days ago) May 29
to Guido Urdaneta, Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Guido Urdaneta and Thomas Nguyen
Ravjit Uppal voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Guido Urdaneta
- Thomas Nguyen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ravjit Uppal (Gerrit)
May 29, 2026, 11:12:36 AM (3 days ago) May 29
to Chromium LUCI CQ, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Ravjit Uppal
Message from Ravjit Uppal![]( "Open in Gerrit")
Attention is currently required from:
- Ravjit Uppal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ravjit Uppal (Gerrit)
May 29, 2026, 11:22:03 AM (3 days ago) May 29
to Guido Urdaneta, Thomas Nguyen, Chromium LUCI CQ, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Guido Urdaneta and Thomas Nguyen
Ravjit Uppal voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Guido Urdaneta
- Thomas Nguyen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ravjit Uppal (Gerrit)
May 29, 2026, 11:22:09 AM (3 days ago) May 29
to Guido Urdaneta, Thomas Nguyen, Chromium LUCI CQ, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Guido Urdaneta and Thomas Nguyen
Ravjit Uppal voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Thomas Nguyen (Gerrit)
10:12 AM (5 hours ago) 10:12 AM
to Ravjit Uppal, Guido Urdaneta, Chromium LUCI CQ, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Guido Urdaneta and Ravjit Uppal
Thomas Nguyen added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/html_user_media_element.cc
Line 190, Patchset 5 (Latest):
HTMLCapabilityElementBase::OnEmbeddedPermissionsDecided(result);Thomas Nguyen . unresolved
I think it does not make sense if we are still firing other events along with onCancel. However, as we are revising the migration logic, the old events should be only fired under the OT token present. Could you please add a note and TODO here?
Related details
Attention is currently required from:
- Guido Urdaneta
- Ravjit Uppal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
11:33 AM (4 hours ago) 11:33 AM
to Ravjit Uppal, Thomas Nguyen, Chromium LUCI CQ, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, tommyw+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Ravjit Uppal
Guido Urdaneta added 5 comments![]( "Open in Gerrit")
File third_party/blink/renderer/modules/mediastream/user_media_request_provider_impl_test.cc
Line 133, Patchset 5 (Latest):
callbacks->OnError(nullptr, error, nullptr, UserMediaRequestResult::kNotFoundError);Guido Urdaneta . unresolved
80 columns?
Line 166, Patchset 5 (Latest):
callbacks->OnError(nullptr, error, nullptr, UserMediaRequestResult::kNotAllowedByUserError);Guido Urdaneta . unresolved
80 columns?
File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/usermedia/oncancel-attribute.html
Line 8, Patchset 5 (Latest):
test(() => {Guido Urdaneta . unresolved
shouldn't you use a promise_test?
Line 18, Patchset 5 (Latest):
assert_true(called, "oncancel IDL attribute should work");Guido Urdaneta . unresolved
Don't you need a promise to wait for the cancel event to fire?
Related details
Attention is currently required from:
- Ravjit Uppal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages