David Grogan (Gerrit)

unread,

Jun 24, 2026, 6:00:30 PM (9 hours ago) Jun 24

to David Grogan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Joey Arhar

David Grogan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joey Arhar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joey Arhar (Gerrit)

unread,

Jun 24, 2026, 6:39:35 PM (8 hours ago) Jun 24

to David Grogan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Joey Arhar voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2026, 6:54:01 PM (8 hours ago) Jun 24

to David Grogan, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Improve appearance:auto ::checkmark for dark mode

This patch makes the ::checkmark for <select multiple size=1> look
better in dark mode when it is not checked by making it have a
transparent fill instead of a white fill. This way, it gets the dark
background color from the picker when it is not checked.

See attached bug for screenshots of this change.

Fixed: 527088945

Change-Id: Ie975821b3fbf623a2b6be3095393a7369f1d18f8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7765563

Commit-Queue: Joey Arhar <jar...@chromium.org>

Reviewed-by: David Grogan <dgr...@chromium.org>

Reviewed-by: Joey Arhar <jar...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1652035}

Files:

M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/web_tests/TestExpectations
M third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/resources/select-multiple-popup-auto-styles.css
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-multiple-popup-auto-appearance-dark-mode-ref.html
A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-multiple-popup-auto-appearance-dark-mode.html

Change size: M

Delta: 5 files changed, 87 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Joey Arhar, +1 by David Grogan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Improve appearance:auto ::checkmark for dark mode [chromium/src : main]

David Grogan (Gerrit)

David Grogan voted Code-Review+1

Related details

Joey Arhar (Gerrit)

Joey Arhar voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information