[Media] Refactor HTMLMediaElement to use FrameVisibilityObserver [chromium/src : main]

0 views
Skip to first unread message

Gabriel Brito (Gerrit)

unread,
2:43 AM (4 hours ago) 2:43 AM
to Dale Curtis, Daniel Cheng, Stefan Zager, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, srirama chandra sekhar, edgecapab...@microsoft.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chfreme...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org, tommyw+w...@chromium.org
Attention needed from Dale Curtis and Daniel Cheng

Gabriel Brito added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gabriel Brito . resolved

Dale and Daniel, could you PTAL when convenient? This refactor should fix some IPC bugs we noticed with the media-playback-while-not-visible permission policy - also makes the code prettier in my opinion 😊

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69af3b0174f69a4092f3144fc9f4af1d49717107
Gerrit-Change-Number: 7278838
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriel Brito <gabrie...@microsoft.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Gabriel Brito <gabrie...@microsoft.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Stefan Zager <sza...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 07:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages