Revert "Remove text node splitting at 64k" [chromium/src : main]

[Kurt Catti-Schmidt (Gerrit)]

Attention needed from Ian Kilpatrick and Mason Freed

Kurt Catti-Schmidt added 1 comment

Commit Message

Line 14, Patchset 1 (Latest):Sample build with failed test: https://ci.chromium.org/b/8678259538770339249
Affected test(s):
[://chrome/test\:browser_tests!gtest::PrefsInternalsTest#TestPrefsAreServed](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::PrefsInternalsTest%23TestPrefsAreServed?q=VHash%3Ac27722ef1c408831)

Kurt Catti-Schmidt . unresolved

These failures seem unrelated - they are mostly unit tests on browser functionality, not the Blink renderer. I noticed this revert hasn't landed yet - is it a false positive?

I don't have access to report it via the link here:

```
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5758846715822080&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7932253&type=BUG
```

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick
• Mason Freed

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I016f0d8abbe240928dc3d39fa32d7807a90ddfe5

Gerrit-Change-Number: 7982465

Gerrit-PatchSet: 1

Gerrit-Owner: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Scott Violet <s...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mason Freed <mas...@chromium.org>

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Jun 2026 18:48:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mason Freed (Gerrit)]

Attention needed from Ian Kilpatrick and Kurt Catti-Schmidt

Mason Freed added 1 comment

Commit Message

Line 14, Patchset 1 (Latest):Sample build with failed test: https://ci.chromium.org/b/8678259538770339249
Affected test(s):
[://chrome/test\:browser_tests!gtest::PrefsInternalsTest#TestPrefsAreServed](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::PrefsInternalsTest%23TestPrefsAreServed?q=VHash%3Ac27722ef1c408831)

Kurt Catti-Schmidt . resolved

These failures seem unrelated - they are mostly unit tests on browser functionality, not the Blink renderer. I noticed this revert hasn't landed yet - is it a false positive?

I don't have access to report it via the link here:

```
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5758846715822080&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7932253&type=BUG
```

Mason Freed

Thanks! I reported it: https://b.corp.google.com/issues/527618926

I'll just abandon this patch.

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick
• Kurt Catti-Schmidt

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I016f0d8abbe240928dc3d39fa32d7807a90ddfe5

Gerrit-Change-Number: 7982465

Gerrit-PatchSet: 1

Gerrit-Owner: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Scott Violet <s...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Jun 2026 00:32:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kurt Catti-Schmidt <ksc...@microsoft.com>

[Mason Freed (Gerrit)]

Mason Freed abandoned this change.

View Change

Abandoned https://b.corp.google.com/issues/527618926

Mason Freed abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon