Forms: Remove Arabic comma from date-time format for RTL locales [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Mar 5, 2026, 7:45:15 AM (2 days ago) Mar 5
to Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I656b6bc06966faf250f5b96eb47ec1dec9bd890b
Gerrit-Change-Number: 7632018
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Mar 2026 12:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Mar 6, 2026, 12:54:15 AM (yesterday) Mar 6
to Kent Tamura, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I656b6bc06966faf250f5b96eb47ec1dec9bd890b
    Gerrit-Change-Number: 7632018
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 05:53:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 6, 2026, 12:58:08 AM (yesterday) Mar 6
    to Kent Tamura, Koji Ishii, AyeAye, chromium...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Forms: Remove Arabic comma from date-time format for RTL locales

    The layout logic for <input type=datetime-local> does not correctly
    handle the ARABIC COMMA (U+060C) in date and time formats.

    Previously, we worked around this by patching the date/time format
    pattern in ICU data. This change moves the workaround into Blink by
    removing the ARABIC COMMA from the format string at runtime for RTL
    locales.

    As the result, this CL fixes the broken layout in Arabic macOS, which
    doesn't use the patched ICU.

    This prepares for the removal of the ICU patch,
    icu/patches/ardatepattern.patch.
    Bug: 40153320, 473861785
    Change-Id: I656b6bc06966faf250f5b96eb47ec1dec9bd890b
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1595184}
    Files:
    • M third_party/blink/renderer/core/html/forms/date_time_local_input_type.cc
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M third_party/blink/renderer/platform/wtf/text/character_names.h
    • M third_party/blink/web_tests/platform/mac-mac13-arm64/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
    • M third_party/blink/web_tests/platform/mac-mac13/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
    • D third_party/blink/web_tests/platform/mac-mac14/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
    • M third_party/blink/web_tests/platform/mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
    Change size: S
    Delta: 7 files changed, 17 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I656b6bc06966faf250f5b96eb47ec1dec9bd890b
    Gerrit-Change-Number: 7632018
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages