[CE] Prevent visited link styling on Capability Elements [chromium/src : main]

0 views
Skip to first unread message

Ravjit Uppal (Gerrit)

unread,
8:20 AM (5 hours ago) 8:20 AM
to android-bu...@system.gserviceaccount.com, Balazs Engedy, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Balazs Engedy

Ravjit Uppal added 1 comment

File third_party/blink/renderer/core/html/html_capability_element_base.cc
Line 944, Patchset 1 (Latest): builder.SetInternalVisitedColor(StyleColor(
Balazs Engedy . unresolved

Is there a way for us to learn if a new kind of color is added that we would need to overwrite here?

Ravjit Uppal

Hmm seems like `builder.SetInsideLink(EInsideLink::kNotInsideLink)` might be a more robust and concise way of fixing it. Let's see what the reviewers have to say.

Open in Gerrit

Related details

Attention is currently required from:
  • Balazs Engedy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I731f378cbee3942d37e6c7e4fc0d9e92dd598016
Gerrit-Change-Number: 7835039
Gerrit-PatchSet: 1
Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-CC: Balazs Engedy <eng...@chromium.org>
Gerrit-Attention: Balazs Engedy <eng...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 12:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Balazs Engedy <eng...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages