[Topics] Consolidate and remove deprecated feature flags [chromium/src : main]
0 views
Skip to first unread message
Yao Xiao (Gerrit)
Jul 30, 2026, 6:52:13 PM (2 days ago) Jul 30
to Dominic Farolino, Abe Boujane, Andrew Paseltiner, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Abe Boujane, Andrew Paseltiner and Dominic Farolino
Yao Xiao voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yao Xiao
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Yao Xiao . resolved
dom@: PTAL at blink and content/child/runtime_features.cc. Thanks!
boujane@: PTAL at privacy_sandbox. Thanks!
apaseltiner@: PTAL privacy_sandbox_ads_apis_browsertest.cc. Thanks!
Related details
Attention is currently required from:
- Abe Boujane
- Andrew Paseltiner
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
Jul 30, 2026, 6:55:00 PM (2 days ago) Jul 30
to Yao Xiao, Abe Boujane, Andrew Paseltiner, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Abe Boujane, Andrew Paseltiner and Yao Xiao
Dominic Farolino voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Abe Boujane
- Andrew Paseltiner
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abe Boujane (Gerrit)
Jul 30, 2026, 8:42:02 PM (2 days ago) Jul 30
to Yao Xiao, Dominic Farolino, Andrew Paseltiner, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Andrew Paseltiner and Yao Xiao
Abe Boujane voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrew Paseltiner
- Yao Xiao
Andrew Paseltiner (Gerrit)
Jul 31, 2026, 8:14:23 AM (18 hours ago) Jul 31
to Yao Xiao, Abe Boujane, Dominic Farolino, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Yao Xiao
Andrew Paseltiner voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Jul 31, 2026, 10:47:33 AM (16 hours ago) Jul 31
to Andrew Paseltiner, Abe Boujane, Dominic Farolino, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Yao Xiao voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 31, 2026, 10:51:43 AM (16 hours ago) Jul 31
to Yao Xiao, Andrew Paseltiner, Abe Boujane, Dominic Farolino, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, droger+w...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Topics] Consolidate and remove deprecated feature flags
The Topics API is being deprecated and was effectively disabled in prior
cleanup work, with web-exposed APIs turned into stubs.
This CL removes redundant feature flags and retains only the main
`TopicsAPI` feature to control the IDL stubs (i.e., we will use Finch to
gradually remove the stubs, mitigating web breakage risks).
Specific changes:
- Merge the `TopicsDocumentAPI` and `TopicsImgAPI` runtime features into
the main `TopicsAPI` runtime feature (controlled by
`network::features::kBrowsingTopics`).
- Remove `kBrowsingTopicsParameters` and `kBrowsingTopicsDocumentAPI`.
- Delete confirmed dead code that still references these parameters.
- Replace the remaining `kBrowsingTopicsTaxonomyVersion` reference with
the default value, to be cleaned up separately.
Bug: 461709147
Change-Id: Iaaeee2b3fb8d517f5876ad3cf28cd3dae01d0078
Commit-Queue: Yao Xiao <yao...@chromium.org>
Reviewed-by: Dominic Farolino <d...@chromium.org>
Reviewed-by: Abe Boujane <bou...@google.com>
Reviewed-by: Andrew Paseltiner <apase...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671841}
Files:
- M components/browsing_topics/common/BUILD.gn
- M components/browsing_topics/common/DEPS
- M components/browsing_topics/common/semantic_tree.cc
- M components/privacy_sandbox/mock_privacy_sandbox_settings.h
- M components/privacy_sandbox/privacy_sandbox_settings.h
- M components/privacy_sandbox/privacy_sandbox_settings_impl.cc
- M components/privacy_sandbox/privacy_sandbox_settings_impl.h
- M components/privacy_sandbox/privacy_sandbox_settings_impl_unittest.cc
- M content/browser/attribution_reporting/privacy_sandbox_ads_apis_browsertest.cc
- M content/child/runtime_features.cc
- M third_party/blink/common/features.cc
- M third_party/blink/public/common/features.h
- M third_party/blink/renderer/core/html/html_image_element.idl
- M third_party/blink/renderer/modules/browsing_topics/browsing_topics_document_supplement.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: L
Delta: 15 files changed, 18 insertions(+), 418 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Farolino, +1 by Andrew Paseltiner, +1 by Abe Boujane
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages