Fix typeahead on appearance:auto <select multiple size=1> [chromium/src : main]

[David Baron (Gerrit)]

Attention needed from Joey Arhar

David Baron voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3022fd89b65f707f2343e74fe5b99517fb5bbbc2

Gerrit-Change-Number: 7719339

Gerrit-PatchSet: 1

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: David Baron <dba...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 15:06:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[David Baron (Gerrit)]

Attention needed from Joey Arhar

David Baron added 1 comment

File third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-multiple-popup-auto-typeahead.html

Line 37, Patchset 1 (Latest): 'No options should be selected after using typeahead.');

David Baron . unresolved

though maybe also worth testing here that the picker is still open?

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3022fd89b65f707f2343e74fe5b99517fb5bbbc2

Gerrit-Change-Number: 7719339

Gerrit-PatchSet: 1

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: David Baron <dba...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 15:07:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Joey Arhar (Gerrit)]

Joey Arhar voted and added 1 comment

Votes added by Joey Arhar

Code-Review	+1
Commit-Queue	+2

1 comment

File third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-multiple-popup-auto-typeahead.html

Line 37, Patchset 1: 'No options should be selected after using typeahead.');

David Baron . resolved

though maybe also worth testing here that the picker is still open?

Joey Arhar

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3022fd89b65f707f2343e74fe5b99517fb5bbbc2

Gerrit-Change-Number: 7719339

Gerrit-PatchSet: 2

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: David Baron <dba...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Wed, 01 Apr 2026 19:59:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: David Baron <dba...@chromium.org>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix typeahead on appearance:auto <select multiple size=1>

Typeahead was selecting options instead of just focusing them like it
does for appearance:auto <select>, but since this mode uses a base
appearance style popover and doesn't have selection-follows-focus, it
should just focus the options without selecting them.

Fixed: 496002560

Change-Id: I3022fd89b65f707f2343e74fe5b99517fb5bbbc2

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7719339

Reviewed-by: Joey Arhar <jar...@chromium.org>

Commit-Queue: Joey Arhar <jar...@chromium.org>

Reviewed-by: David Baron <dba...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1608844}

Files:

• M third_party/blink/renderer/core/html/forms/html_select_element.cc
• A third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-multiple-popup-auto-typeahead.html

Change size: S

Delta: 2 files changed, 42 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Joey Arhar, +1 by David Baron

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3022fd89b65f707f2343e74fe5b99517fb5bbbc2

Gerrit-Change-Number: 7719339

Gerrit-PatchSet: 3

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>