bindings: Remove references to ConstructorCallWith. [chromium/src : main]

Raphael Kubo da Costa (Gerrit)

unread,

Sep 20, 2021, 12:18:36 PM9/20/21

to Kentaro Hara, Yuki Shiino, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, gogerald+pa...@chromium.org, jmedle...@chromium.org, maxlg+pay...@chromium.org, nburris+pa...@chromium.org, rouslan+...@chromium.org, Raphael Kubo da Costa

Attention is currently required from: Kentaro Hara, Yuki Shiino.

Raphael Kubo da Costa would like Kentaro Hara and Yuki Shiino to review this change.

View Change

bindings: Remove references to ConstructorCallWith.

The new bindings generator does not support it at all, so having this
line was a no-nop (also manually verified by diff'ing the generated
files with and without this attribute). All IDL files that actually
needed something like ConstructorCallWith have already been converted to
use NamedConstructor_CallWith=Document in
https://chromium-review.googlesource.com/c/chromium/src/+/2132011

Bug: 839389
Change-Id: I24c317a0943c174194ddf4247144176350bbf1dc
---
M third_party/blink/renderer/bindings/IDLExtendedAttributes.md
M third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
M third_party/blink/renderer/core/html/forms/html_option_element.idl
M third_party/blink/renderer/core/html/html_image_element.idl
M third_party/blink/renderer/core/html/media/html_audio_element.idl
M third_party/blink/renderer/modules/payments/payment_manager.idl
6 files changed, 3 insertions(+), 41 deletions(-)

To view, visit change 3171294. To unsubscribe, or for help writing mail filters, visit settings.

Raphael Kubo da Costa (Gerrit)

unread,

Sep 20, 2021, 12:18:43 PM9/20/21

to Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, gogerald+pa...@chromium.org, jmedle...@chromium.org, maxlg+pay...@chromium.org, nburris+pa...@chromium.org, rouslan+...@chromium.org, Kentaro Hara, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar

Attention is currently required from: Kentaro Hara, Yuki Shiino.

Patch set 1:Auto-Submit +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  +haraken for blanket approval for all the IDL files
  +yukishiino to double-check the change

To view, visit change 3171294. To unsubscribe, or for help writing mail filters, visit settings.

Kentaro Hara (Gerrit)

unread,

Sep 20, 2021, 12:24:18 PM9/20/21

to Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, gogerald+pa...@chromium.org, jmedle...@chromium.org, maxlg+pay...@chromium.org, nburris+pa...@chromium.org, rouslan+...@chromium.org, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar

Attention is currently required from: Raphael Kubo da Costa, Yuki Shiino.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #1:
  LGTM

To view, visit change 3171294. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Sep 20, 2021, 2:49:57 PM9/20/21

to Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, gogerald+pa...@chromium.org, jmedle...@chromium.org, maxlg+pay...@chromium.org, nburris+pa...@chromium.org, rouslan+...@chromium.org, Kentaro Hara, Yuki Shiino, chromium...@chromium.org, srirama chandra sekhar

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Kentaro Hara: Looks good to me; Commit
  Raphael Kubo da Costa: Dry run; Send CL to CQ automatically after approval

bindings: Remove references to ConstructorCallWith.

The new bindings generator does not support it at all, so having this
line was a no-nop (also manually verified by diff'ing the generated
files with and without this attribute). All IDL files that actually
needed something like ConstructorCallWith have already been converted to
use NamedConstructor_CallWith=Document in
https://chromium-review.googlesource.com/c/chromium/src/+/2132011

Bug: 839389
Change-Id: I24c317a0943c174194ddf4247144176350bbf1dc

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171294
Commit-Queue: Raphael Kubo da Costa <raphael.ku...@intel.com>
Commit-Queue: Kentaro Hara <har...@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.ku...@intel.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922996}


---
M third_party/blink/renderer/bindings/IDLExtendedAttributes.md
M third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
M third_party/blink/renderer/core/html/forms/html_option_element.idl
M third_party/blink/renderer/core/html/html_image_element.idl
M third_party/blink/renderer/core/html/media/html_audio_element.idl
M third_party/blink/renderer/modules/payments/payment_manager.idl
6 files changed, 3 insertions(+), 41 deletions(-)

To view, visit change 3171294. To unsubscribe, or for help writing mail filters, visit settings.

Yuki Shiino (Gerrit)

unread,

Sep 21, 2021, 2:04:02 AM9/21/21

to Raphael Kubo da Costa, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, gogerald+pa...@chromium.org, jmedle...@chromium.org, maxlg+pay...@chromium.org, nburris+pa...@chromium.org, rouslan+...@chromium.org, Yuki Shiino, Kentaro Hara, chromium...@chromium.org, srirama chandra sekhar

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  LGTM! Thanks for the clean-up.

To view, visit change 3171294. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward