Move inline CSS to fix blob iframe CSP errors [chromium/src : main]

0 views
Skip to first unread message

Olga Korokhina (Gerrit)

unread,
Oct 17, 2025, 8:32:11 AM (2 days ago) Oct 17
to Nico Weber, Abigail Klein, Simon Hangl, Chris Thompson, Robbie McElrath, AyeAye, Alexis Menard, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, James Maclean, Chromium LUCI CQ, andy...@google.com, oshima...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdf-r...@chromium.org, yuzo+...@chromium.org
Attention needed from Abigail Klein, Chris Thompson, Nico Weber, Robbie McElrath and Simon Hangl

Olga Korokhina added 1 comment

Commit Message
Line 7, Patchset 7:Change moves inline css classes causing CSP error for iFrame
Simon Hangl . resolved

nit: usually we try to provide 1-line headings

Olga Korokhina

I failed to squeeze all the context in one line, let's keep it as an exception this way, some of reviewers are not involved in bugs related discussions so we need as much context as we can have.

Chris Thompson

Suggestion: "Move inline CSS to fix blob iframe CSP errors" (and then move this full sentence into the description perhaps)

Olga Korokhina

Addressed, thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Abigail Klein
  • Chris Thompson
  • Nico Weber
  • Robbie McElrath
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98abb62b8a6ec8557e4dae34bb665c478b279806
Gerrit-Change-Number: 7031803
Gerrit-PatchSet: 9
Gerrit-Owner: Olga Korokhina <koro...@google.com>
Gerrit-Reviewer: Abigail Klein <abigai...@google.com>
Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Robbie McElrath <rmce...@chromium.org>
Gerrit-Attention: Chris Thompson <cth...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Abigail Klein <abigai...@google.com>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Fri, 17 Oct 2025 12:31:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chris Thompson <cth...@chromium.org>
Comment-In-Reply-To: Simon Hangl <sim...@google.com>
Comment-In-Reply-To: Olga Korokhina <koro...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Korokhina (Gerrit)

unread,
Oct 17, 2025, 9:30:30 AM (2 days ago) Oct 17
to Nico Weber, Abigail Klein, Simon Hangl, Chris Thompson, Robbie McElrath, AyeAye, Alexis Menard, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, James Maclean, Chromium LUCI CQ, andy...@google.com, oshima...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdf-r...@chromium.org, yuzo+...@chromium.org
Attention needed from Abigail Klein, Chris Thompson, Nico Weber, Robbie McElrath and Simon Hangl

Olga Korokhina added 1 comment

File third_party/blink/renderer/core/html/resources/html.css
Line 1565, Patchset 7:pre.wrap-pre {
Abigail Klein . resolved

I don't think it's a good idea to have a class name in this official css file. That would affect developers who use this same class name.

Olga Korokhina

How would you recommend to have this selector?

Olga Korokhina

@abigai...@google.com I've replaced class with name and made it less like to be used by someone outside, chrome#wrap-pre . How to you think if this is a) the right direction? 2) enough unique name?

Gerrit-Comment-Date: Fri, 17 Oct 2025 13:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Abigail Klein <abigai...@google.com>
Comment-In-Reply-To: Olga Korokhina <koro...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Korokhina (Gerrit)

unread,
Oct 17, 2025, 9:32:36 AM (2 days ago) Oct 17
to Nico Weber, Abigail Klein, Simon Hangl, Chris Thompson, Robbie McElrath, AyeAye, Alexis Menard, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, James Maclean, Chromium LUCI CQ, andy...@google.com, oshima...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdf-r...@chromium.org, yuzo+...@chromium.org
Attention needed from Abigail Klein, Chris Thompson, Nico Weber, Robbie McElrath and Simon Hangl

Olga Korokhina added 1 comment

File components/webapps/isolated_web_apps/url_loading/url_loader_factory.cc
Line 87, Patchset 5: "style-src 'self';"
Olga Korokhina . resolved

This left here for the purpose of testing for one who wants to fetch and try the CL, will be reverted before merge.

Olga Korokhina

Tests are failing because of this, once we revert it tests will go fine.

Olga Korokhina

Set to proper value, ready to merge.

Open in Gerrit

Related details

Attention is currently required from:
  • Abigail Klein
  • Chris Thompson
  • Nico Weber
  • Robbie McElrath
  • Simon Hangl
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98abb62b8a6ec8557e4dae34bb665c478b279806
    Gerrit-Change-Number: 7031803
    Gerrit-PatchSet: 10
    Gerrit-Owner: Olga Korokhina <koro...@google.com>
    Gerrit-Reviewer: Abigail Klein <abigai...@google.com>
    Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
    Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Robbie McElrath <rmce...@chromium.org>
    Gerrit-Attention: Chris Thompson <cth...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Abigail Klein <abigai...@google.com>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Comment-Date: Fri, 17 Oct 2025 13:32:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Olga Korokhina <koro...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages