[SVG] Introducing Page-level `MemoryCache` for SVG resources. [chromium/src : main]

0 views
Skip to first unread message

Kurt Catti-Schmidt (Gerrit)

unread,
Aug 13, 2025, 1:18:04 PMAug 13
to Divyansh Mangal, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal

Kurt Catti-Schmidt added 1 comment

File third_party/blink/renderer/core/loader/resource/svg_document_resource.cc
Line 49, Patchset 32 (Latest): MemoryCache* local_svg_memory_cache_ = nullptr;
Kurt Catti-Schmidt . unresolved

This should be `Member<MemoryCache>`, otherwise it could be disposed at any point.

"In a garbage-collected class, on-heap objects must be retained by Member<T> or WeakMember<T>"

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/heap/BlinkGCAPIReference.md

This will also require it to be traced via `Trace`

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I31a48601bcdaf80a5cb76aebd99669d46cb36cf1
Gerrit-Change-Number: 6774503
Gerrit-PatchSet: 32
Gerrit-Owner: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Wed, 13 Aug 2025 17:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 13, 2025, 1:50:23 PMAug 13
to Divyansh Mangal, Kurt Catti-Schmidt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/motionmark1.3.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12f81f59910000

Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Wed, 13 Aug 2025 17:50:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 13, 2025, 2:39:57 PMAug 13
to Divyansh Mangal, Kurt Catti-Schmidt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/motionmark1.3.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1276c433910000

Gerrit-Comment-Date: Wed, 13 Aug 2025 18:39:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 13, 2025, 3:19:16 PMAug 13
to Divyansh Mangal, Kurt Catti-Schmidt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/rendering.desktop.notracing complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/179ec433910000

Gerrit-Comment-Date: Wed, 13 Aug 2025 19:19:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 13, 2025, 3:20:12 PMAug 13
to Divyansh Mangal, Kurt Catti-Schmidt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Divyansh Mangal

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/139ec433910000

Gerrit-Comment-Date: Wed, 13 Aug 2025 19:19:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Divyansh Mangal (Gerrit)

unread,
Sep 17, 2025, 1:26:16 PM (2 days ago) Sep 17
to chrom...@appspot.gserviceaccount.com, Kurt Catti-Schmidt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Stephen Chenney, loading-rev...@chromium.org, devtools-re...@chromium.org, blink-rev...@chromium.org, dcheng+c...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org

Divyansh Mangal abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages