[style] Drop Box suffix from IsDisplaySomethingBox. [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
May 11, 2026, 5:46:05 PM (20 hours ago) May 11
to David Grogan, Menard, Alexis, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from David Grogan

Ian Kilpatrick voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Grogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iea03fe2b7a8e6eef38c03bfa241e46b5f55caa83
Gerrit-Change-Number: 7836825
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: David Grogan <dgr...@chromium.org>
Gerrit-Comment-Date: Mon, 11 May 2026 21:46:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Grogan (Gerrit)

unread,
May 11, 2026, 5:52:12 PM (20 hours ago) May 11
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

David Grogan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iea03fe2b7a8e6eef38c03bfa241e46b5f55caa83
    Gerrit-Change-Number: 7836825
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Mon, 11 May 2026 21:52:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    May 11, 2026, 5:58:55 PM (20 hours ago) May 11
    to David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

    Ian Kilpatrick voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iea03fe2b7a8e6eef38c03bfa241e46b5f55caa83
      Gerrit-Change-Number: 7836825
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Mon, 11 May 2026 21:58:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      May 11, 2026, 10:19:19 PM (15 hours ago) May 11
      to Ian Kilpatrick, David Grogan, Menard, Alexis, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [style] Drop Box suffix from IsDisplaySomethingBox.

      We are going to add IsDisplayWebkitBox. With this suffix it would be
      IsDisplayWebkitBoxBox which isn't great.

      Remove IsDisplayFlexibleOrGridBox as it didn't add much value.

      There should be no behaviour change.
      Change-Id: Iea03fe2b7a8e6eef38c03bfa241e46b5f55caa83
      Auto-Submit: Ian Kilpatrick <ikilp...@chromium.org>
      Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
      Reviewed-by: David Grogan <dgr...@chromium.org>
      Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1628966}
      Files:
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
      • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
      • M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
      • M third_party/blink/renderer/core/editing/commands/editing_commands_utilities.cc
      • M third_party/blink/renderer/core/inspector/inspector_highlight.cc
      • M third_party/blink/renderer/core/layout/custom/pending_layout_registry.cc
      • M third_party/blink/renderer/core/layout/grid/grid_item.cc
      • M third_party/blink/renderer/core/layout/grid/grid_line_resolver.cc
      • M third_party/blink/renderer/core/layout/grid/grid_track_collection.cc
      • M third_party/blink/renderer/core/layout/inline/logical_line_builder.cc
      • M third_party/blink/renderer/core/layout/layout_block_flow.cc
      • M third_party/blink/renderer/core/layout/length_utils.cc
      • M third_party/blink/renderer/core/mathml/mathml_padded_element.cc
      • M third_party/blink/renderer/core/mathml/mathml_radical_element.cc
      • M third_party/blink/renderer/core/mathml/mathml_row_element.cc
      • M third_party/blink/renderer/core/mathml/mathml_token_element.cc
      • M third_party/blink/renderer/core/style/computed_style.cc
      • M third_party/blink/renderer/core/style/computed_style.h
      Change size: M
      Delta: 18 files changed, 72 insertions(+), 79 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, +1 by David Grogan
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iea03fe2b7a8e6eef38c03bfa241e46b5f55caa83
      Gerrit-Change-Number: 7836825
      Gerrit-PatchSet: 3
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages