Measure click events from synthesized middle-clicks [chromium/src : main]

0 views

Skip to first unread message

Mason Freed (Gerrit)

unread,

7:51 PM (4 hours ago) 7:51 PM

to Emily Stark, Daniel Cheng, Arthur Sonzogni, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Emily Stark

Mason Freed voted and added 3 comments

Votes added by Mason Freed

Code-Review

3 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Mason Freed . unresolved

Looks good! Modulo a few questions

File third_party/blink/renderer/core/html/html_anchor_element.cc

Line 559, Patchset 5 (Latest): event.button() == 1) {

Mason Freed . unresolved

while a bit ugly, I think the proper thing would be

```
event.button() == static_cast<int16_t>(WebPointerProperties::Button::kMiddle);
```

File third_party/blink/web_tests/fast/events/pointerevents/synthesized-middle-click-use-counter.html

Line 6, Patchset 5 (Latest): <a id="link" href="#">Link</a>

Mason Freed . unresolved

Are you interested in other anchor links? E.g.

```
<map id="m">
  <area href="" shape="default">
</map>
<img src="" usemap="#map1">

<svg xmlns="http://www.w3.org/2000/svg">
  <a href=""><text>link</text></a>
</svg>
```

Open in Gerrit

Related details

Attention is currently required from:

Emily Stark

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages