[webmcp] Add basic unit tests for UpdateMcpDefinitionsIfNeeded [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Jan 22, 2026, 9:40:23 AMJan 22
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jan 23, 2026, 1:23:04 PMJan 23
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 23, 2026, 9:57:39 PMJan 23
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 23, 2026, 10:29:10 PMJan 23
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Anders Hartvoll Ruud . resolved
Review-Enforcement problems ...
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 23, 2026, 10:29:13 PMJan 23
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 23, 2026, 11:42:47 PMJan 23
to Anders Hartvoll Ruud, Mason Freed, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webmcp] Add basic unit tests for UpdateMcpDefinitionsIfNeeded
This CL adds unit tests to verify that we do (or do not) end up
with a valid declarative WebMCP tool given changing attributes
and document-connectedness.
While these tests are useful in their own right, the real purpose
of this CL is to have a natural place to drop a future unit test
for pseudo-class state invalidation (:tool-form-active, to begin with).
It's possible that we'll *also* want to add a test to
ActorToolsTestScriptTool for this, but that will be evaluated later.
Bug: 475992364
Change-Id: I43330f24508a6e4e977d0435501fb7ff36670dc5
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1574118}
Files:
- M third_party/blink/renderer/core/html/build.gni
- M third_party/blink/renderer/core/html/forms/html_form_element.cc
- M third_party/blink/renderer/core/html/forms/html_form_element.h
- A third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
Change size: M
Delta: 4 files changed, 166 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed, +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages