[A11y] Use aria-describedby for calendar-picker month selector [chromium/src : main]

[David Segovia (Gerrit)]

Attention needed from David Tseng, Khushal Sagar, Lucas Radaelli and Xiaocheng Hu

David Segovia added 1 comment

Patchset-level comments

File-level comment, Patchset 3:

Aaron Leventhal . resolved

Usually in accessibility the label (aka accessible name) is separate from what is currently selected in a control, which is exposed either as a value, or a selection, or both. The name is generally expanded to stay constant but the value or selection represents changeable data. It's like "what is this thing" vs "what data does it hold right now".

So on the surface, changing the label doesn't seem like the right approach. However, exceptions are sometimes made to hack around legacy screen reader behavior, as a matter of pragmatism.

I'll paste this into the filed bug to get feedback from the reporter.

Temporarily marking -1 until we get clarity on the approach.

David Segovia

Hi Aaron, I appreciate the catch. I’m going to look into how Firefox handles this. I'll update the PR once I have a better fix. Thanks!

Aaron Leventhal

Hi David. Feel free to run it by me. It might end up not being the best to follow what Firefox does. We should see if it makes sense. At the moment, I think what we expose to screen readers is pretty good, but they aren't picking up on it.

David Segovia

Hi Aaron, I agree with you. I'm trying to find out why the current version isn't being announced. It looks like Firefox handles this by putting the aria-label on the parent container instead of the button itself. This seems like an easy fix for us since the affected container only has one child (the month-selector button).

I’m planning to update the CL to mirror this approach and do some testing with more ATs, but wanted to get your thoughts first. Thanks!

Aaron Leventhal

Looks like aria-label is a hacky approach they used, so we should make a concrete decision on whether it's worth dying on that hill or just following their approach and getting the fix. I'm surprised, because their team is usually more on the of clean APIs and standards and this is looks like a pragmatic thing. Might be worth having someone reach out to them to ask.

Aaron Leventhal

Another thing to do is to look at what HTML-AAM says, and ask Scott O'Hara who is the editor for it.

David Segovia

Hi Aaron, thank you so much for your help. I really appreciate the opportunity to learn. I’ve been digging into the resources you mentioned and also went back to the Firefox implementation.

I was mistaken.They don't label the parent of the button. Instead, they put the aria-label and a specific role (role="dialog") on the popup container that appears after the click.

This way, the AT announces the current value of the button first, and when the user clicks, it announces the popup's label to tell them where they just landed ("Choose a month and a year, dialog"). I think this follows the standard much better. Please let me know what do you think. Thanks!

David Segovia

Done

Open in Gerrit

Related details

Attention is currently required from:

• David Tseng
• Khushal Sagar
• Lucas Radaelli
• Xiaocheng Hu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4011964600051ad2b16ac4963153d2450807b9a7

Gerrit-Change-Number: 7713041

Gerrit-PatchSet: 11

Gerrit-Owner: David Segovia <davids...@google.com>

Gerrit-Reviewer: David Segovia <davids...@google.com>

Gerrit-Reviewer: David Tseng <dts...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>

Gerrit-Reviewer: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>

Gerrit-Comment-Date: Tue, 21 Apr 2026 16:54:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aaron Leventhal <aleve...@google.com>

Comment-In-Reply-To: David Segovia <davids...@google.com>

[Khushal Sagar (Gerrit)]

Attention needed from Aaron Leventhal, David Segovia, David Tseng, Lucas Radaelli and Xiaocheng Hu

Khushal Sagar added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Khushal Sagar . resolved

I can take a look once Aaron is happy with it.

Open in Gerrit

Related details

Attention is currently required from:

• Aaron Leventhal
• David Segovia
• David Tseng
• Lucas Radaelli
• Xiaocheng Hu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4011964600051ad2b16ac4963153d2450807b9a7

Gerrit-Change-Number: 7713041

Gerrit-PatchSet: 11

Gerrit-Owner: David Segovia <davids...@google.com>

Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>

Gerrit-Reviewer: David Segovia <davids...@google.com>

Gerrit-Reviewer: David Tseng <dts...@chromium.org>

Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>

Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>

Gerrit-Reviewer: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Aaron Leventhal <aleve...@google.com>

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: David Segovia <davids...@google.com>

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:32:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Aaron Leventhal (Gerrit)]

Attention needed from David Segovia, David Tseng, Lucas Radaelli and Xiaocheng Hu

Aaron Leventhal added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Aaron Leventhal . resolved

David Segovia, have you tried reaching out to the current a11y team?

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: David Segovia <davids...@google.com>

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:35:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[David Segovia (Gerrit)]

Attention needed from David Tseng, Lucas Radaelli and Xiaocheng Hu

David Segovia added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Aaron Leventhal . resolved

David Segovia, have you tried reaching out to the current a11y team?

David Segovia

Hi Aaron, yup. I reached out to Lucas. I've added him as a reviewer along with David Tseng.

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:38:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aaron Leventhal <aleve...@google.com>

[Lucas Radaelli (Gerrit)]

Attention needed from Aaron Leventhal, David Segovia, David Tseng and Xiaocheng Hu

Lucas Radaelli added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Aaron Leventhal . resolved

David Segovia, have you tried reaching out to the current a11y team?

David Segovia

Hi Aaron, yup. I reached out to Lucas. I've added him as a reviewer along with David Tseng.

Lucas Radaelli

Yep, we meet yesterday. I just asked David to add a test here and update the change to be ready for final review and ping me.

Open in Gerrit

Related details

Attention is currently required from:

• Aaron Leventhal
• David Segovia
• David Tseng

• Xiaocheng Hu

Gerrit-Attention: Aaron Leventhal <aleve...@google.com>

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: David Segovia <davids...@google.com>

Gerrit-Attention: David Tseng <dts...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:59:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aaron Leventhal <aleve...@google.com>

Comment-In-Reply-To: David Segovia <davids...@google.com>