Align MathML nonce implementation with SVG/HTML. [chromium/src : main]

0 views
Skip to first unread message

Frédéric Wang Nélar (Gerrit)

unread,
May 11, 2026, 7:19:42 AM (yesterday) May 11
to Kinuko Yasuda, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Kinuko Yasuda

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kinuko Yasuda
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
Gerrit-Change-Number: 7827786
Gerrit-PatchSet: 1
Gerrit-Owner: Frédéric Wang Nélar <fw...@igalia.com>
Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
Gerrit-Comment-Date: Mon, 11 May 2026 11:19:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
May 11, 2026, 7:22:52 PM (18 hours ago) May 11
to Frédéric Wang Nélar, chromium...@chromium.org, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Frédéric Wang Nélar

Ian Kilpatrick voted and added 2 comments

Votes added by Ian Kilpatrick

Code-Review+1

2 comments

File third_party/blink/renderer/core/mathml/mathml_element.cc
Line 130, Patchset 1 (Latest): // MathMLElement, HTMLElement and SVGElement are handling "nonce" the same
// way.
Ian Kilpatrick . unresolved
```suggestion
  // MathMLElement, HTMLElement and SVGElement handle "nonce" the same way.
```
File third_party/blink/renderer/core/svg/svg_element.cc
Line 496, Patchset 1 (Latest): // SVGElement, HTMLElement and MathMLElement are handling "nonce" the same
// way.
Ian Kilpatrick . unresolved
```suggestion
  // MathMLElement, HTMLElement and SVGElement handle "nonce" the same way.
```
Open in Gerrit

Related details

Attention is currently required from:
  • Frédéric Wang Nélar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
    Gerrit-Change-Number: 7827786
    Gerrit-PatchSet: 1
    Gerrit-Owner: Frédéric Wang Nélar <fw...@igalia.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Frédéric Wang Nélar <fw...@igalia.com>
    Gerrit-Comment-Date: Mon, 11 May 2026 23:22:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Frédéric Wang Nélar (Gerrit)

    unread,
    1:02 AM (13 hours ago) 1:02 AM
    to Ian Kilpatrick, chromium...@chromium.org, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org

    Frédéric Wang Nélar added 2 comments

    File third_party/blink/renderer/core/mathml/mathml_element.cc
    Line 130, Patchset 1: // MathMLElement, HTMLElement and SVGElement are handling "nonce" the same
    // way.
    Ian Kilpatrick . resolved
    ```suggestion
      // MathMLElement, HTMLElement and SVGElement handle "nonce" the same way.
    ```
    Frédéric Wang Nélar

    Done

    File third_party/blink/renderer/core/svg/svg_element.cc
    Line 496, Patchset 1: // SVGElement, HTMLElement and MathMLElement are handling "nonce" the same
    // way.
    Ian Kilpatrick . resolved
    ```suggestion
      // MathMLElement, HTMLElement and SVGElement handle "nonce" the same way.
    ```
    Frédéric Wang Nélar

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
      Gerrit-Change-Number: 7827786
      Gerrit-PatchSet: 2
      Gerrit-Owner: Frédéric Wang Nélar <fw...@igalia.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Tue, 12 May 2026 05:02:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>
      satisfied_requirement
      open
      diffy

      Frédéric Wang Nélar (Gerrit)

      unread,
      2:23 AM (11 hours ago) 2:23 AM
      to Chromium LUCI CQ, Ian Kilpatrick, chromium...@chromium.org, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org

      Frédéric Wang Nélar voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
      Gerrit-Change-Number: 7827786
      Gerrit-PatchSet: 2
      Gerrit-Owner: Frédéric Wang Nélar <fw...@igalia.com>
      Gerrit-Reviewer: Frédéric Wang Nélar <fw...@igalia.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Tue, 12 May 2026 06:23:18 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      2:43 AM (11 hours ago) 2:43 AM
      to Frédéric Wang Nélar, Ian Kilpatrick, chromium...@chromium.org, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/core/svg/svg_element.cc
      Insertions: 1, Deletions: 2.

      @@ -493,8 +493,7 @@
       }
       
       void SVGElement::ParseAttribute(const AttributeModificationParams& params) {
      -  // SVGElement, HTMLElement and MathMLElement are handling "nonce" the same
      -  // way.
      +  // SVGElement, HTMLElement and MathMLElement handle "nonce" the same way.
         if (params.name == html_names::kNonceAttr) {
           if (params.new_value != g_empty_atom)
             setNonce(params.new_value);
      ```
      ```
      The name of the file: third_party/blink/renderer/core/mathml/mathml_element.cc
      Insertions: 1, Deletions: 2.

      @@ -127,8 +127,7 @@
       }
       
       void MathMLElement::ParseAttribute(const AttributeModificationParams& param) {
      -  // MathMLElement, HTMLElement and SVGElement are handling "nonce" the same
      -  // way.
      +  // MathMLElement, HTMLElement and SVGElement handle "nonce" the same way.
         if (param.name == html_names::kNonceAttr) {
           if (param.new_value != g_empty_atom) {
             setNonce(param.new_value);
      ```

      Change information

      Bug: 469878491
      Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
      Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
      Commit-Queue: Frédéric Wang Nélar <fw...@igalia.com>
      Cr-Commit-Position: refs/heads/main@{#1629086}
      Files:
      • M third_party/blink/renderer/core/dom/element.h
      • M third_party/blink/renderer/core/mathml/mathml_element.cc
      • M third_party/blink/renderer/core/mathml/mathml_element.h
      • M third_party/blink/renderer/core/svg/svg_element.cc
      Change size: S
      Delta: 4 files changed, 20 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ian Kilpatrick
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e3b77791eba23708bcbf1fafc57036eb45c96b
      Gerrit-Change-Number: 7827786
      Gerrit-PatchSet: 3
      Gerrit-Owner: Frédéric Wang Nélar <fw...@igalia.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Frédéric Wang Nélar <fw...@igalia.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages