Improve customizable select light dismiss detection [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Dec 16, 2025, 7:02:58 PM (3 days ago) Dec 16
to AyeAye, Chromium LUCI CQ, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted and added 2 comments

Votes added by Mason Freed

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Mason Freed . resolved

LGTM, with a few nits in one.

File third_party/blink/renderer/core/html/html_element.cc
Line 2240, Patchset 4 (Latest): if (auto* select = DynamicTo<HTMLSelectElement>(test_node)) {
Mason Freed . unresolved

Maybe add a `// Case 5. ...` comment?

Actually though, I'd insert this case above the current `case 4` because it's more specific and less experimental.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1488ccdf3addf0df69ca252fcbb56da433bf3f6b
Gerrit-Change-Number: 6912976
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 00:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Dec 17, 2025, 5:52:37 PM (2 days ago) Dec 17
to Mason Freed, AyeAye, Chromium LUCI CQ, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Joey Arhar voted and added 1 comment

Votes added by Joey Arhar

Code-Review+1
Commit-Queue+2

1 comment

File third_party/blink/renderer/core/html/html_element.cc
Line 2240, Patchset 4: if (auto* select = DynamicTo<HTMLSelectElement>(test_node)) {
Mason Freed . resolved

Maybe add a `// Case 5. ...` comment?

Actually though, I'd insert this case above the current `case 4` because it's more specific and less experimental.

Joey Arhar

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1488ccdf3addf0df69ca252fcbb56da433bf3f6b
    Gerrit-Change-Number: 6912976
    Gerrit-PatchSet: 5
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 22:52:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 17, 2025, 7:14:21 PM (2 days ago) Dec 17
    to Mason Freed, AyeAye, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Improve customizable select light dismiss detection

    This patch prevents customizable select's popover from being light
    dismissed when the user clicks on the select to invoke the popover in a
    less hacky way.

    Spec PR: https://github.com/whatwg/html/pull/12008
    Change-Id: I1488ccdf3addf0df69ca252fcbb56da433bf3f6b
    Reviewed-by: Joey Arhar <jar...@chromium.org>
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Commit-Queue: Joey Arhar <jar...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1560264}
    Files:
    • M third_party/blink/renderer/core/html/html_element.cc
    Change size: S
    Delta: 1 file changed, 10 insertions(+), 11 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joey Arhar, +1 by Mason Freed
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1488ccdf3addf0df69ca252fcbb56da433bf3f6b
    Gerrit-Change-Number: 6912976
    Gerrit-PatchSet: 6
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages