Add origin trial integration for OpaqueRange [chromium/src : main]

0 views
Skip to first unread message

Stephanie Zhang (Gerrit)

unread,
Mar 31, 2026, 7:01:34 PM (2 days ago) Mar 31
to chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Message from Stephanie Zhang

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
Gerrit-Change-Number: 7719389
Gerrit-PatchSet: 1
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 23:01:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephanie Zhang (Gerrit)

unread,
Mar 31, 2026, 7:01:54 PM (2 days ago) Mar 31
to Dan Clark, Leo Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark

Stephanie Zhang voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
Gerrit-Change-Number: 7719389
Gerrit-PatchSet: 1
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-CC: Leo Lee <leo...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 23:01:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dan Clark (Gerrit)

unread,
Mar 31, 2026, 7:39:26 PM (2 days ago) Mar 31
to Stephanie Zhang, Ana Sollano Kim, Leo Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ana Sollano Kim and Stephanie Zhang

Dan Clark voted and added 1 comment

Votes added by Dan Clark

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Ana Sollano Kim
  • Stephanie Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
Gerrit-Change-Number: 7719389
Gerrit-PatchSet: 1
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-CC: Leo Lee <leo...@microsoft.com>
Gerrit-Attention: Ana Sollano Kim <anso...@microsoft.com>
Gerrit-Attention: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 23:39:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephanie Zhang (Gerrit)

unread,
Apr 1, 2026, 2:15:57 PM (16 hours ago) Apr 1
to Mason Freed, Leo Lee, Ana Sollano Kim, Dan Clark, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Stephanie Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Stephanie Zhang . resolved

PTAL - thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
Gerrit-Change-Number: 7719389
Gerrit-PatchSet: 2
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-CC: Ana Sollano Kim <anso...@microsoft.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 18:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Apr 1, 2026, 8:07:43 PM (10 hours ago) Apr 1
to Stephanie Zhang, Leo Lee, Ana Sollano Kim, Dan Clark, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Stephanie Zhang

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stephanie Zhang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
    Gerrit-Change-Number: 7719389
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-CC: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:07:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Stephanie Zhang (Gerrit)

    unread,
    Apr 1, 2026, 8:10:36 PM (10 hours ago) Apr 1
    to Mason Freed, Leo Lee, Ana Sollano Kim, Dan Clark, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Stephanie Zhang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
    Gerrit-Change-Number: 7719389
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-CC: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:10:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 11:06:56 PM (7 hours ago) Apr 1
    to Stephanie Zhang, Mason Freed, Leo Lee, Ana Sollano Kim, Dan Clark, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add origin trial integration for OpaqueRange

    Add origin_trial_feature_name to the OpaqueRange runtime enabled feature
    and update all callers of OpaqueRangeEnabled() to pass ExecutionContext.
    Low-Coverage-Reason: COVERAGE_UNDERREPORTED
    Bug: 421421332
    Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
    Commit-Queue: Stephanie Zhang <stephan...@microsoft.com>
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Reviewed-by: Dan Clark <dan...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1608933}
    Files:
    • M third_party/blink/renderer/core/dom/opaque_range.cc
    • M third_party/blink/renderer/core/highlight/highlight_registry.cc
    • M third_party/blink/renderer/core/html/forms/html_input_element.cc
    • M third_party/blink/renderer/core/html/forms/html_text_area_element.cc
    • M third_party/blink/renderer/core/html/forms/text_control_element.cc
    • M third_party/blink/renderer/core/html/forms/text_field_input_type.cc
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    Change size: M
    Delta: 7 files changed, 35 insertions(+), 22 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mason Freed, +1 by Dan Clark
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83bbd9b2516e77e90f9aefea6ef65e1eed30c40d
    Gerrit-Change-Number: 7719389
    Gerrit-PatchSet: 3
    Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-CC: Ana Sollano Kim <anso...@microsoft.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages