[layout] Convert core/html/forms to using StyleRef() [chromium/src : main]
0 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
Jul 31, 2026, 3:14:21 PM (11 hours ago) Jul 31
to David Grogan, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Grogan
Ian Kilpatrick voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
Jul 31, 2026, 3:27:08 PM (11 hours ago) Jul 31
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick
David Grogan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Jul 31, 2026, 3:46:05 PM (11 hours ago) Jul 31
to David Grogan, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Ian Kilpatrick voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 31, 2026, 4:26:29 PM (10 hours ago) Jul 31
to Ian Kilpatrick, David Grogan, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[layout] Convert core/html/forms to using StyleRef()
The style is null on a LayoutObject for a very small period of time.
Most callers shouldn't have to check if the style is null.
Switch the accessors Style() within core/html/forms to either using
StyleRef() directly or not checking if the Style() is null at all.
There should be no behaviour change.
Change-Id: Iaa7b0f39973d55780f47fe9166d116b15aa68ad4
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: David Grogan <dgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1672067}
Files:
- M third_party/blink/renderer/core/html/forms/html_select_element.cc
- M third_party/blink/renderer/core/html/forms/slider_thumb_element.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Grogan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages