Kent Tamura (Gerrit)

unread,

2:00 AM (21 hours ago) 2:00 AM

to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org

Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4:

Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:

Fredrik Söderquist

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fredrik Söderquist (Gerrit)

unread,

4:57 AM (18 hours ago) 4:57 AM

to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org

Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:05 AM (18 hours ago) 5:05 AM

to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

WTF: Rename CharactersToInt() and CharactersToUInt()

This change renames `CharactersToInt()` and `CharactersToUInt()` to
`StringToInt()` and `StringToUint()` respectively. This is to be more
consistent with other `StringToFoo` functions in `string_to_number.h`.

The new functions now return a `std::optional` instead of using a `bool*
ok` out-parameter to indicate whether parsing was successful. The call
sites of the renamed functions have been updated to use the new
`std::optional`-based API.

Bug: 473854537

Change-Id: I70ec2722d3c6179222324f26cbffb53cdb103f30

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7564909

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Auto-Submit: Kent Tamura <tk...@chromium.org>

Commit-Queue: Fredrik Söderquist <f...@opera.com>

Cr-Commit-Position: refs/heads/main@{#1583092}

Files:

M third_party/blink/renderer/core/html/anchor_element_metrics.cc
M third_party/blink/renderer/core/page/create_window.cc
M third_party/blink/renderer/core/timing/background_tracing_helper.cc
M third_party/blink/renderer/core/url_pattern/url_pattern.cc
M third_party/blink/renderer/platform/wtf/text/string_to_number.cc
M third_party/blink/renderer/platform/wtf/text/string_to_number.h

Change size: M

Delta: 6 files changed, 37 insertions(+), 47 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fredrik Söderquist

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

WTF: Rename CharactersToInt() and CharactersToUInt() [chromium/src : main]

Kent Tamura (Gerrit)

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

1 comment

Related details

Fredrik Söderquist (Gerrit)

Fredrik Söderquist voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information