Shared Storage: Clean up more unused code [chromium/src : main]

0 views

Skip to first unread message

Cammie Smith Barnes (Gerrit)

unread,

Jul 31, 2026, 5:42:11 PM (9 hours ago) Jul 31

to Yao Xiao, Kevin McNee, Nate Chapin, Chromium Metrics Reviews, Peter Beverloo, James Maclean, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, edgesto...@microsoft.com, subresource-f...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, storage...@chromium.org, asvitkine...@chromium.org, dmurph+watching...@chromium.org, gavinp...@chromium.org, ios-r...@chromium.org, headless...@chromium.org, ios-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, dullweb...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, android-web...@chromium.org, navigation...@chromium.org, csharris...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, blink-re...@chromium.org, speed-metrics...@chromium.org, apaselti...@chromium.org, msrame...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org

Attention needed from Yao Xiao

Cammie Smith Barnes added 2 comments

Patchset-level comments

File-level comment, Patchset 26 (Latest):

Cammie Smith Barnes . resolved

@yao...@chromium.org, PTAL, thanks!

File services/network/public/cpp/permissions_policy/permissions_policy_unittest.cc

Line 2392, Patchset 26 (Latest):TEST_F(PermissionsPolicyTest, ProposedTestIsFeatureEnabledForOriginDefaultAll) {

Cammie Smith Barnes . unresolved

DO you think it would be ok for us to just remove this test instead?

Open in Gerrit

Related details

Attention is currently required from:

Yao Xiao

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yao Xiao (Gerrit)

unread,

Jul 31, 2026, 7:28:52 PM (7 hours ago) Jul 31

to Cammie Smith Barnes, Kevin McNee, Nate Chapin, Chromium Metrics Reviews, Peter Beverloo, James Maclean, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, edgesto...@microsoft.com, subresource-f...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, storage...@chromium.org, asvitkine...@chromium.org, dmurph+watching...@chromium.org, gavinp...@chromium.org, ios-r...@chromium.org, headless...@chromium.org, ios-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, dullweb...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, android-web...@chromium.org, navigation...@chromium.org, csharris...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, blink-re...@chromium.org, speed-metrics...@chromium.org, apaselti...@chromium.org, msrame...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org

Attention needed from Cammie Smith Barnes

Yao Xiao voted and added 2 comments

Votes added by Yao Xiao

Code-Review

2 comments

File services/network/public/cpp/permissions_policy/permissions_policy_unittest.cc

Line 2392, Patchset 26 (Latest):TEST_F(PermissionsPolicyTest, ProposedTestIsFeatureEnabledForOriginDefaultAll) {

Cammie Smith Barnes . unresolved

DO you think it would be ok for us to just remove this test instead?

Yao Xiao

I think this might be a general infrastructure test, even though it originated from the Privacy Sandbox APIs. Let's keep it, at least for this CL.

Line 2394, Patchset 26 (Latest): network::mojom::PermissionsPolicyFeature::kBrowsingTopics;

Yao Xiao . unresolved

Since the inline comment specifically discusses `joinAdInterestGroup`, it looks like this should be `kJoinAdInterestGroup` in the first place to match the context?