[Mojo/Content] Define Immersive Picture-In-Picture Playback Mojo and C++ interfaces [chromium/src : main]

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Andrey Kosyakov, Chromium IPC Reviews, Foromo Daniel Soromou, Joey Arhar, Rakina Zata Amni and Wenyu Fu

Oleh Desiatyrikov (xWF) added 1 comment

Patchset-level comments

File-level comment, Patchset 26 (Latest):

Oleh Desiatyrikov (xWF) . resolved

Hi everyone, sorry for the broad CC! I'm adding you all for OWNERS coverage across the various directories touched by this change.

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Chromium IPC Reviews
• Foromo Daniel Soromou
• Joey Arhar
• Rakina Zata Amni
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0464e30e1a2ca3bd4267d0b23dd0cc251fce5b88

Gerrit-Change-Number: 7717398

Gerrit-PatchSet: 26

Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gurmeet Kalra <gurm...@google.com>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Yizhi Zhao <yi...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Apr 2026 18:43:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Giovanni Ortuno Urquidi, Joey Arhar, Rakina Zata Amni and Wenyu Fu

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org

Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Giovanni Ortuno Urquidi

• Joey Arhar
• Rakina Zata Amni
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0464e30e1a2ca3bd4267d0b23dd0cc251fce5b88

Gerrit-Change-Number: 7717398

Gerrit-PatchSet: 26

Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gurmeet Kalra <gurm...@google.com>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Yizhi Zhao <yi...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Apr 2026 18:49:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Wenyu Fu (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Giovanni Ortuno Urquidi, Joey Arhar, Oleh Desiatyrikov (xWF) and Rakina Zata Amni

Wenyu Fu voted and added 1 comment

Votes added by Wenyu Fu

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 26 (Latest):

Wenyu Fu . resolved

chrome/browser/android LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Giovanni Ortuno Urquidi
• Joey Arhar

• Oleh Desiatyrikov (xWF)
• Rakina Zata Amni

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Apr 2026 19:00:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Andrey Kosyakov (Gerrit)]

Attention needed from Foromo Daniel Soromou, Giovanni Ortuno Urquidi, Joey Arhar, Oleh Desiatyrikov (xWF) and Rakina Zata Amni

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 26 (Latest):

Andrey Kosyakov . resolved

headless/ rslgtm

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Fri, 17 Apr 2026 20:30:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Foromo Daniel Soromou (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joey Arhar, Oleh Desiatyrikov (xWF) and Rakina Zata Amni

Foromo Daniel Soromou voted and added 1 comment

Votes added by Foromo Daniel Soromou

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 26 (Latest):

Foromo Daniel Soromou . resolved

c/b/ui/views/overlay LGTM

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Comment-Date: Sat, 18 Apr 2026 08:12:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Rakina Zata Amni (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joey Arhar and Oleh Desiatyrikov (xWF)

Rakina Zata Amni added 2 comments

File content/public/browser/video_picture_in_picture_window_controller.h

Line 88, Patchset 26 (Latest): virtual bool IsImmersive() const = 0;

Rakina Zata Amni . unresolved

Can this just be in the impl class instead?

File content/public/browser/web_contents_delegate.h

Line 948, Patchset 26 (Latest): // Returns true if immersive playback is enabled.
virtual bool IsImmersivePlaybackEnabled() const;

// Requests a confirmation from the user to enter immersive playback.
virtual void RequestImmersivePlaybackConfirmation(
base::OnceCallback<
void(blink::mojom::ImmersivePlaybackConfirmationResultPtr)> callback);

Rakina Zata Amni . unresolved

Are these overridden by embedders outside of `//content`? If not maybe this shouldn't be in `//content/public`?

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Joey Arhar
• Oleh Desiatyrikov (xWF)

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Comment-Date: Mon, 20 Apr 2026 14:08:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joey Arhar and Rakina Zata Amni

Oleh Desiatyrikov (xWF) added 2 comments

File content/public/browser/video_picture_in_picture_window_controller.h

Line 88, Patchset 26 (Latest): virtual bool IsImmersive() const = 0;

Rakina Zata Amni . resolved

Can this just be in the impl class instead?

Oleh Desiatyrikov (xWF)

This will be used here [1] to determine a window type to instantiate.

[1] http://chromium-review.git.corp.google.com/c/chromium/src/+/7717381/18/chrome/browser/ui/android/overlay/overlay_window_android_factory.cc

File content/public/browser/web_contents_delegate.h

Line 948, Patchset 26 (Latest): // Returns true if immersive playback is enabled.
virtual bool IsImmersivePlaybackEnabled() const;

// Requests a confirmation from the user to enter immersive playback.
virtual void RequestImmersivePlaybackConfirmation(
base::OnceCallback<
void(blink::mojom::ImmersivePlaybackConfirmationResultPtr)> callback);

Rakina Zata Amni . resolved

Are these overridden by embedders outside of `//content`? If not maybe this shouldn't be in `//content/public`?

Oleh Desiatyrikov (xWF)

These will be overwritten by web_contents_delegate_android [1] and tab_web_contents_delegate_android [2].

[1] https://chromium-review.git.corp.google.com/c/chromium/src/+/7717379/12/components/embedder_support/android/delegate/web_contents_delegate_android.cc
[2] https://chromium-review.git.corp.google.com/c/chromium/src/+/7715888/15/chrome/browser/android/tab_web_contents_delegate_android.cc

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Joey Arhar

• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Apr 2026 15:06:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Joey Arhar, Oleh Desiatyrikov (xWF) and Rakina Zata Amni

Giovanni Ortuno Urquidi added 1 comment

File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom

Line 132, Patchset 26 (Latest): RequestImmersivePlaybackConfirmation()

Giovanni Ortuno Urquidi . unresolved

Doesn't look like this is called by anything? Mojo reviews require all methods to have non-test usage. You'll have to add this when it's used.

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Oleh Desiatyrikov (xWF)

• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Apr 2026 17:37:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joey Arhar and Rakina Zata Amni

Oleh Desiatyrikov (xWF) added 1 comment

File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom

Line 132, Patchset 26 (Latest): RequestImmersivePlaybackConfirmation()

Giovanni Ortuno Urquidi . unresolved

Doesn't look like this is called by anything? Mojo reviews require all methods to have non-test usage. You'll have to add this when it's used.

Oleh Desiatyrikov (xWF)

The next CL [1] in the chain is adding a use case for this method. I've made it separate so it's easier to review. Should I combine these two?

[1] https://chromium-review.git.corp.google.com/c/chromium/src/+/7716732

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Joey Arhar

• Rakina Zata Amni

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Apr 2026 19:30:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

[Rakina Zata Amni (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi, Joey Arhar and Oleh Desiatyrikov (xWF)

Rakina Zata Amni voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi
• Joey Arhar

• Oleh Desiatyrikov (xWF)

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 06:34:37 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Joey Arhar and Oleh Desiatyrikov (xWF)

Giovanni Ortuno Urquidi added 1 comment

File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom

Line 132, Patchset 26 (Latest): RequestImmersivePlaybackConfirmation()

Giovanni Ortuno Urquidi . unresolved

Doesn't look like this is called by anything? Mojo reviews require all methods to have non-test usage. You'll have to add this when it's used.

Oleh Desiatyrikov (xWF)

The next CL [1] in the chain is adding a use case for this method. I've made it separate so it's easier to review. Should I combine these two?

[1] https://chromium-review.git.corp.google.com/c/chromium/src/+/7716732

Giovanni Ortuno Urquidi

Is there going to be a browser-side check that ensure the renderer has user confirmation for immersive PiP?

What about removing it from the Mojo interface and the service and adding it in the next CL? Would that add too much to the follow up CL?

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Comment-Date: Tue, 21 Apr 2026 15:20:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Oleh Desiatyrikov (xWF) <desiat...@google.com>