Move MenuItemList to shared template class [chromium/src : main]

0 views

Skip to first unread message

David Baron (Gerrit)

unread,

May 7, 2026, 3:02:15 PM (5 days ago) May 7

to David Baron, Menard, Alexis, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, dgroga...@chromium.org, dbaro...@chromium.org

Attention needed from Joey Arhar

David Baron added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

David Baron . resolved

I will wait for the next round of replies on the CL underneath this one before reviewing this one.

Open in Gerrit

Related details

Attention is currently required from:

Joey Arhar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Baron (Gerrit)

unread,

9:53 AM (4 hours ago) 9:53 AM

Attention needed from Joey Arhar

David Baron voted and added 1 comment

Votes added by David Baron

Code-Review

1 comment

File third_party/blink/renderer/core/html/forms/option_list.h

Line 68, Patchset 6 (Latest): DCHECK_EQ(&owner_, &other.owner_);

David Baron . unresolved

I'd prefer this as a `CHECK()` rather than a `DCHECK()`; the implications of being wrong are probably bad.