[Blink] Move CanvasResourceHost::size_ to CanvasRenderingContextHost [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Jun 24, 2025, 11:05:59 AMJun 24
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Saifuddin Hitawala . resolved

LGTM, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaa180a909edf74ca37f956af6204101bdae65e18
Gerrit-Change-Number: 6664540
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Jun 2025 15:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 25, 2025, 3:38:19 AMJun 25
to Colin Blundell, Saifuddin Hitawala, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Blink] Move CanvasResourceHost::size_ to CanvasRenderingContextHost

Nothing needs it on CanvasResourceHost.
Bug: 352263194
Change-Id: Iaa180a909edf74ca37f956af6204101bdae65e18
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478392}
Files:
  • M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
  • M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
  • M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
  • M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
  • M third_party/blink/renderer/platform/graphics/canvas_hibernation_handler_test.cc
  • M third_party/blink/renderer/platform/graphics/canvas_resource_host.cc
  • M third_party/blink/renderer/platform/graphics/canvas_resource_host.h
Change size: S
Delta: 7 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Saifuddin Hitawala
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaa180a909edf74ca37f956af6204101bdae65e18
Gerrit-Change-Number: 6664540
Gerrit-PatchSet: 3
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages