[webmcp] Expect :tool-form-active on <form> elements [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Jan 22, 2026, 8:37:27 AMJan 22
to Rune Lillesveen, Mason Freed, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Anders Hartvoll Ruud . resolved
ptal. I'll hold off on landing until I confirm that this was the intent.
Related details
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jan 22, 2026, 8:51:42 AMJan 22
to Anders Hartvoll Ruud, Rune Lillesveen, Mason Freed, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Rune Lillesveen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 23, 2026, 4:30:45 AMJan 23
to Rune Lillesveen, Mason Freed, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 23, 2026, 5:14:43 AMJan 23
to Anders Hartvoll Ruud, Rune Lillesveen, Mason Freed, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webmcp] Expect :tool-form-active on <form> elements
We're currently set up to handle these pseudo-class states
on form *control* elements, but it should have been form elements.
Unfortunately, it's not possible to write a test against this
in its current state.
Bug: 475992364
Change-Id: I47d1efd4a020ad2ec4d9b6c897bbde3a4e4abfec
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573576}
Files:
- M third_party/blink/renderer/core/css/selector_checker.cc
- M third_party/blink/renderer/core/html/forms/html_form_control_element.h
- M third_party/blink/renderer/core/html/forms/html_form_element.h
- M third_party/blink/renderer/core/html/resources/html.css
Change size: S
Delta: 4 files changed, 24 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages