Ensure slot change signals follow tree order [chromium/src : main]
0 views
Skip to first unread message
YeongHan Kim (Gerrit)
Oct 16, 2025, 11:42:14 AM (3 days ago) Oct 16
to Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
YeongHan Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Oct 17, 2025, 7:27:27 PM (2 days ago) Oct 17
to YeongHan Kim, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from YeongHan Kim
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- YeongHan Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jinho Bang (Gerrit)
Oct 18, 2025, 2:11:51 AM (yesterday) Oct 18
to YeongHan Kim, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from YeongHan Kim
Jinho Bang voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- YeongHan Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 18, 2025, 4:22:46 AM (yesterday) Oct 18
to YeongHan Kim, Jinho Bang, Mason Freed, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ensure slot change signals follow tree order
The WPT test is failing because the slot change signal is not enqueue in
tree order.
According to [1], assign slottables should be run for each slot in tree
order. Current implementation, when there is a change in slottables, the
slot change signal is enqueue immediately without considering the order.
However, there is no guarantee that slottable changes follow the tree
order of the slots. So, the slot change signal may be enqueue in the
wrong order.
This patch fixes the bug by ensuring that slot change signals are
enqueue in tree order, regardless of the order in which slottables
change.
[1] https://dom.spec.whatwg.org/#assign-slotables-for-a-tree
Bug: 40587295
Change-Id: I8eb4e1a7c56ab50474ac568c95c752966d282164
Commit-Queue: Jinho Bang <zi...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Reviewed-by: Jinho Bang <zi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531797}
Files:
- M third_party/blink/renderer/core/html/html_slot_element.cc
- D third_party/blink/web_tests/external/wpt/shadow-dom/imperative-slot-api-slotchange-expected.txt
Change size: S
Delta: 2 files changed, 14 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jinho Bang, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages