Revert "Make Supplementable array-based." [chromium/src : main]

0 views

Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,

Dec 10, 2025, 7:51:58 AM (3 days ago) Dec 10

to Arnaud Mandy, Permissions Reviews, Rijubrata Bhaumik, Kaan Icer, Nate Chapin, Raphael Kubo da Costa, Simon Hangl, Hiroki Nakagawa, Luna Lu, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Gyuyoung Kim, Daniel Cheng, Wanming Lin, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Wang, Wei4, Andrew Rayskiy, Xida Chen, Kenneth R Christiansen, prerendering-reviews, Stephen Chenney, David Bokan, Christian Biesinger, Hongchan Choi, Yoav Weiss (@Shopify), Dirk Schulze, Peter Beverloo, iclella...@chromium.org, blink-rev...@chromium.org, nator...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, npm+...@chromium.org, dtapuska+...@chromium.org, storage...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, dmurph+watch...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, kinuko...@chromium.org, giovax...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org, kinuko+...@chromium.org, gl...@chromium.org, kainin...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, servicewor...@chromium.org, dcheng+c...@chromium.org, speed-metrics...@chromium.org, eric.c...@apple.com, rmcelra...@chromium.org, kouhe...@chromium.org, webap...@microsoft.com, blink-re...@chromium.org, odejesu...@chromium.org, horo+...@chromium.org, mattreyno...@chromium.org, silv...@chromium.org, blink-revi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, sloboda...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, dmurph+watchi...@chromium.org, toyosh...@chromium.org, webauthn...@chromium.org, dmurph+wa...@chromium.org, jkarli...@chromium.org, rayanka...@chromium.org, yigu+...@chromium.org, aleventh...@chromium.org, mgiuca...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, video-networking...@google.com, edgesto...@microsoft.com, derinel+wat...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, pkotwic...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, web-schedulin...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org

Attention needed from Daniel Cheng

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Daniel Cheng to review this change.

Commit message

Revert "Make Supplementable array-based."

This reverts commit a0c6dba59914aec4a758d89508e39e0c524abad6.
(See blink-dev for background.)

Bug: 460165754

Change-Id: I91fa12fdc9d5d393ecc5b6e8896d9ec809d88827

Change diff

Change information

Files:

M third_party/blink/renderer/controller/dev_tools_frontend_impl.cc
M third_party/blink/renderer/controller/dev_tools_frontend_impl.h
M third_party/blink/renderer/core/annotation/annotation_agent_container_impl.cc
M third_party/blink/renderer/core/annotation/annotation_agent_container_impl.h
M third_party/blink/renderer/core/clipboard/data_object.cc
M third_party/blink/renderer/core/clipboard/data_object.h
M third_party/blink/renderer/core/context_features/context_feature_settings.cc
M third_party/blink/renderer/core/context_features/context_feature_settings.h
M third_party/blink/renderer/core/css/css_selector_watch.cc
M third_party/blink/renderer/core/css/css_selector_watch.h
M third_party/blink/renderer/core/css/font_face_set_document.cc
M third_party/blink/renderer/core/css/font_face_set_document.h
M third_party/blink/renderer/core/css/font_face_set_worker.cc
M third_party/blink/renderer/core/css/font_face_set_worker.h
M third_party/blink/renderer/core/dom/abort_signal_registry.cc
M third_party/blink/renderer/core/dom/abort_signal_registry.h
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/document.h
M third_party/blink/renderer/core/dom/document_parser_timing.cc
M third_party/blink/renderer/core/dom/document_parser_timing.h
M third_party/blink/renderer/core/dom/mutation_observer.cc
M third_party/blink/renderer/core/dom/range.cc
M third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
M third_party/blink/renderer/core/editing/suggestion/text_suggestion_backend_impl.cc
M third_party/blink/renderer/core/editing/suggestion/text_suggestion_backend_impl.h
M third_party/blink/renderer/core/execution_context/agent.cc
M third_party/blink/renderer/core/execution_context/agent.h
M third_party/blink/renderer/core/execution_context/execution_context.cc
M third_party/blink/renderer/core/execution_context/execution_context.h
M third_party/blink/renderer/core/execution_context/navigator_base.cc
M third_party/blink/renderer/core/execution_context/navigator_base.h
M third_party/blink/renderer/core/fetch/global_fetch.cc
M third_party/blink/renderer/core/fileapi/file_backed_blob_factory_dispatcher.cc
M third_party/blink/renderer/core/fileapi/file_backed_blob_factory_dispatcher.h
M third_party/blink/renderer/core/fileapi/file_reader.cc
M third_party/blink/renderer/core/frame/cached_permission_status.cc
M third_party/blink/renderer/core/frame/cached_permission_status.h
M third_party/blink/renderer/core/frame/local_dom_window.cc
M third_party/blink/renderer/core/frame/local_dom_window.h
M third_party/blink/renderer/core/frame/local_frame.cc
M third_party/blink/renderer/core/frame/local_frame.h
M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/frame/navigator.cc
M third_party/blink/renderer/core/frame/navigator.h
M third_party/blink/renderer/core/frame/navigator_user_activation.cc
M third_party/blink/renderer/core/frame/navigator_user_activation.h
M third_party/blink/renderer/core/frame/picture_in_picture_controller.cc
M third_party/blink/renderer/core/frame/picture_in_picture_controller.h
M third_party/blink/renderer/core/frame/reporting_context.cc
M third_party/blink/renderer/core/frame/reporting_context.h
M third_party/blink/renderer/core/frame/scheduling.cc
M third_party/blink/renderer/core/frame/scheduling.h
M third_party/blink/renderer/core/frame/screen.cc
M third_party/blink/renderer/core/frame/screen.h
M third_party/blink/renderer/core/frame/universal_global_scope.cc
M third_party/blink/renderer/core/frame/universal_global_scope.h
M third_party/blink/renderer/core/fullscreen/fullscreen.cc
M third_party/blink/renderer/core/fullscreen/fullscreen.h
M third_party/blink/renderer/core/geolocation/geolocation.cc
M third_party/blink/renderer/core/geolocation/geolocation.h
M third_party/blink/renderer/core/highlight/highlight_registry.cc
M third_party/blink/renderer/core/highlight/highlight_registry.h
M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
M third_party/blink/renderer/core/html/anchor_element_metrics_sender.h
M third_party/blink/renderer/core/html/anchor_element_viewport_position_tracker.cc
M third_party/blink/renderer/core/html/anchor_element_viewport_position_tracker.h
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
M third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.h
M third_party/blink/renderer/core/html/fenced_frame/document_fenced_frames.cc
M third_party/blink/renderer/core/html/fenced_frame/document_fenced_frames.h
M third_party/blink/renderer/core/html/html_iframe_element.cc
M third_party/blink/renderer/core/html/html_iframe_element.h
M third_party/blink/renderer/core/html/media/audio_output_device_controller.cc
M third_party/blink/renderer/core/html/media/audio_output_device_controller.h
M third_party/blink/renderer/core/html/media/html_media_element.cc
M third_party/blink/renderer/core/html/media/html_media_element.h
M third_party/blink/renderer/core/html/media/html_video_element.cc
M third_party/blink/renderer/core/html/media/html_video_element.h
M third_party/blink/renderer/core/html/media/remote_playback_controller.cc
M third_party/blink/renderer/core/html/media/remote_playback_controller.h
M third_party/blink/renderer/core/html/media/video_frame_callback_requester.cc
M third_party/blink/renderer/core/html/media/video_frame_callback_requester.h
M third_party/blink/renderer/core/html/track/track_base.cc
M third_party/blink/renderer/core/html/track/track_base.h
M third_party/blink/renderer/core/inspector/inspector_media_context_impl.cc
M third_party/blink/renderer/core/inspector/inspector_media_context_impl.h
M third_party/blink/renderer/core/layout/custom/layout_worklet.cc
M third_party/blink/renderer/core/layout/custom/layout_worklet.h
M third_party/blink/renderer/core/loader/interactive_detector.cc
M third_party/blink/renderer/core/loader/interactive_detector.h
M third_party/blink/renderer/core/loader/no_state_prefetch_client.cc
M third_party/blink/renderer/core/loader/no_state_prefetch_client.h
M third_party/blink/renderer/core/mojo/mojo.h
M third_party/blink/renderer/core/page/page.cc
M third_party/blink/renderer/core/page/page.h
M third_party/blink/renderer/core/page/page_popup_controller.cc
M third_party/blink/renderer/core/page/page_popup_controller.h
M third_party/blink/renderer/core/paint/timing/container_timing.h
M third_party/blink/renderer/core/paint/timing/image_element_timing.cc
M third_party/blink/renderer/core/paint/timing/image_element_timing.h
M third_party/blink/renderer/core/paint/timing/paint_timing.cc
M third_party/blink/renderer/core/paint/timing/paint_timing.h
M third_party/blink/renderer/core/paint/timing/text_element_timing.cc
M third_party/blink/renderer/core/paint/timing/text_element_timing.h
M third_party/blink/renderer/core/patching/patch_supplement.cc
M third_party/blink/renderer/core/patching/patch_supplement.h
M third_party/blink/renderer/core/permissions_policy/permissions_policy_parser.cc
M third_party/blink/renderer/core/preferences/navigator_preferences.cc
M third_party/blink/renderer/core/preferences/navigator_preferences.h
M third_party/blink/renderer/core/resize_observer/resize_observer_controller.cc
M third_party/blink/renderer/core/resize_observer/resize_observer_controller.h
M third_party/blink/renderer/core/route_matching/route_map.cc
M third_party/blink/renderer/core/route_matching/route_map.h
M third_party/blink/renderer/core/scheduler/dom_scheduler.cc
M third_party/blink/renderer/core/scheduler/dom_scheduler.h
M third_party/blink/renderer/core/scheduler/dom_timer.cc
M third_party/blink/renderer/core/scheduler/scripted_idle_task_controller.cc
M third_party/blink/renderer/core/scheduler/scripted_idle_task_controller.h
M third_party/blink/renderer/core/script_tools/model_context_supplement.cc
M third_party/blink/renderer/core/script_tools/model_context_supplement.h
M third_party/blink/renderer/core/shadow_realm/shadow_realm_global_scope.cc
M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.cc
M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.h
M third_party/blink/renderer/core/testing/internal_settings.cc
M third_party/blink/renderer/core/timing/global_performance.cc
M third_party/blink/renderer/core/timing/render_blocking_metrics_reporter.cc
M third_party/blink/renderer/core/timing/render_blocking_metrics_reporter.h
M third_party/blink/renderer/core/timing/third_party_script_detector.cc
M third_party/blink/renderer/core/timing/third_party_script_detector.h
M third_party/blink/renderer/core/workers/shared_worker.cc
M third_party/blink/renderer/core/workers/shared_worker.h
M third_party/blink/renderer/core/workers/shared_worker_client_holder.cc
M third_party/blink/renderer/core/workers/shared_worker_client_holder.h
M third_party/blink/renderer/core/workers/worker_clients.h
M third_party/blink/renderer/core/workers/worker_global_scope.cc
M third_party/blink/renderer/core/workers/worker_global_scope.h
M third_party/blink/renderer/core/xml/document_xpath_evaluator.cc
M third_party/blink/renderer/core/xml/document_xpath_evaluator.h
M third_party/blink/renderer/core/xml/document_xslt.cc
M third_party/blink/renderer/core/xml/document_xslt.h
M third_party/blink/renderer/extensions/chromeos/kiosk/cros_kiosk.cc
M third_party/blink/renderer/extensions/chromeos/kiosk/cros_kiosk.h
M third_party/blink/renderer/extensions/webview/web_view_android.cc
M third_party/blink/renderer/extensions/webview/web_view_android.h
M third_party/blink/renderer/modules/ad_auction/navigator_auction.cc
M third_party/blink/renderer/modules/ad_auction/navigator_auction.h
M third_party/blink/renderer/modules/ai/ai_interface_proxy.cc
M third_party/blink/renderer/modules/ai/ai_interface_proxy.h
M third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc
M third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.h
M third_party/blink/renderer/modules/animationworklet/css_animation_worklet.cc
M third_party/blink/renderer/modules/animationworklet/css_animation_worklet.h
M third_party/blink/renderer/modules/app_banner/app_banner_controller.cc
M third_party/blink/renderer/modules/app_banner/app_banner_controller.h
M third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
M third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h
M third_party/blink/renderer/modules/background_fetch/service_worker_registration_background_fetch.cc
M third_party/blink/renderer/modules/background_fetch/service_worker_registration_background_fetch.h
M third_party/blink/renderer/modules/background_sync/service_worker_registration_sync.cc
M third_party/blink/renderer/modules/background_sync/service_worker_registration_sync.h
M third_party/blink/renderer/modules/badging/navigator_badge.cc
M third_party/blink/renderer/modules/badging/navigator_badge.h
M third_party/blink/renderer/modules/battery/battery_manager.cc
M third_party/blink/renderer/modules/battery/battery_manager.h
M third_party/blink/renderer/modules/beacon/navigator_beacon.cc
M third_party/blink/renderer/modules/beacon/navigator_beacon.h
M third_party/blink/renderer/modules/bluetooth/bluetooth.cc
M third_party/blink/renderer/modules/bluetooth/bluetooth.h
M third_party/blink/renderer/modules/browsing_topics/browsing_topics_document_supplement.cc
M third_party/blink/renderer/modules/browsing_topics/browsing_topics_document_supplement.h
M third_party/blink/renderer/modules/buckets/storage_bucket_manager.cc
M third_party/blink/renderer/modules/buckets/storage_bucket_manager.h
M third_party/blink/renderer/modules/cache_storage/global_cache_storage.cc
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_factories.cc
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_factories.h
M third_party/blink/renderer/modules/clipboard/clipboard.cc
M third_party/blink/renderer/modules/clipboard/clipboard.h
M third_party/blink/renderer/modules/clipboard/clipboard_change_event_controller.cc
M third_party/blink/renderer/modules/clipboard/clipboard_change_event_controller.h
M third_party/blink/renderer/modules/compute_pressure/pressure_observer_manager.cc
M third_party/blink/renderer/modules/compute_pressure/pressure_observer_manager.h
M third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
M third_party/blink/renderer/modules/contacts_picker/contacts_manager.h
M third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.cc
M third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.h
M third_party/blink/renderer/modules/content_extraction/frame_metadata_observer_registry.cc
M third_party/blink/renderer/modules/content_extraction/frame_metadata_observer_registry.h
M third_party/blink/renderer/modules/content_extraction/inner_html_agent.cc
M third_party/blink/renderer/modules/content_extraction/inner_html_agent.h
M third_party/blink/renderer/modules/content_extraction/inner_text_agent.cc
M third_party/blink/renderer/modules/content_extraction/inner_text_agent.h
M third_party/blink/renderer/modules/content_index/service_worker_registration_content_index.cc
M third_party/blink/renderer/modules/content_index/service_worker_registration_content_index.h
M third_party/blink/renderer/modules/cookie_deprecation_label/cookie_deprecation_label.cc
M third_party/blink/renderer/modules/cookie_deprecation_label/cookie_deprecation_label.h
M third_party/blink/renderer/modules/cookie_store/cookie_store_manager.cc
M third_party/blink/renderer/modules/cookie_store/cookie_store_manager.h
M third_party/blink/renderer/modules/cookie_store/global_cookie_store.cc
M third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
M third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.h
M third_party/blink/renderer/modules/credentialmanagement/credential_manager_proxy.cc
M third_party/blink/renderer/modules/credentialmanagement/credential_manager_proxy.h
M third_party/blink/renderer/modules/credentialmanagement/credential_metrics.cc
M third_party/blink/renderer/modules/credentialmanagement/credential_metrics.h
M third_party/blink/renderer/modules/credentialmanagement/navigator_login.cc
M third_party/blink/renderer/modules/credentialmanagement/navigator_login.h
M third_party/blink/renderer/modules/crypto/dom_window_crypto.cc
M third_party/blink/renderer/modules/crypto/dom_window_crypto.h
M third_party/blink/renderer/modules/crypto/worker_global_scope_crypto.cc
M third_party/blink/renderer/modules/crypto/worker_global_scope_crypto.h
M third_party/blink/renderer/modules/csspaint/paint_worklet.cc
M third_party/blink/renderer/modules/csspaint/paint_worklet.h
M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.cc
M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.h
M third_party/blink/renderer/modules/delegated_ink/ink.cc
M third_party/blink/renderer/modules/delegated_ink/ink.h
M third_party/blink/renderer/modules/device_orientation/device_motion_controller.cc
M third_party/blink/renderer/modules/device_orientation/device_motion_controller.h
M third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.cc
M third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.h
M third_party/blink/renderer/modules/device_orientation/device_orientation_controller.cc
M third_party/blink/renderer/modules/device_orientation/device_orientation_controller.h
M third_party/blink/renderer/modules/device_posture/navigator_device_posture.cc
M third_party/blink/renderer/modules/device_posture/navigator_device_posture.h
M third_party/blink/renderer/modules/document_metadata/document_metadata_server.cc
M third_party/blink/renderer/modules/document_metadata/document_metadata_server.h
M third_party/blink/renderer/modules/document_picture_in_picture/document_picture_in_picture.cc
M third_party/blink/renderer/modules/document_picture_in_picture/document_picture_in_picture.h
M third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.cc
M third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.h
M third_party/blink/renderer/modules/file_system_access/file_system_access_manager.cc
M third_party/blink/renderer/modules/file_system_access/file_system_access_manager.h
M third_party/blink/renderer/modules/file_system_access/file_system_observation_collection.cc
M third_party/blink/renderer/modules/file_system_access/file_system_observation_collection.h
M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.cc
M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.h
M third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc
M third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h
M third_party/blink/renderer/modules/filesystem/local_file_system.cc
M third_party/blink/renderer/modules/filesystem/local_file_system.h
M third_party/blink/renderer/modules/font_access/font_access.cc
M third_party/blink/renderer/modules/font_access/font_access.h
M third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
M third_party/blink/renderer/modules/gamepad/navigator_gamepad.h
M third_party/blink/renderer/modules/handwriting/handwriting_recognition_service.cc
M third_party/blink/renderer/modules/handwriting/handwriting_recognition_service.h
M third_party/blink/renderer/modules/hid/hid.cc
M third_party/blink/renderer/modules/hid/hid.h
M third_party/blink/renderer/modules/idle/idle_manager.cc
M third_party/blink/renderer/modules/idle/idle_manager.h
M third_party/blink/renderer/modules/image_downloader/image_downloader_impl.cc
M third_party/blink/renderer/modules/image_downloader/image_downloader_impl.h
M third_party/blink/renderer/modules/indexeddb/global_indexed_db.cc
M third_party/blink/renderer/modules/installation/installation_service_impl.cc
M third_party/blink/renderer/modules/installation/installation_service_impl.h
M third_party/blink/renderer/modules/installedapp/installed_app_controller.cc
M third_party/blink/renderer/modules/installedapp/installed_app_controller.h
M third_party/blink/renderer/modules/keyboard/navigator_keyboard.cc
M third_party/blink/renderer/modules/keyboard/navigator_keyboard.h
M third_party/blink/renderer/modules/launch/dom_window_launch_queue.cc
M third_party/blink/renderer/modules/launch/dom_window_launch_queue.h
M third_party/blink/renderer/modules/launch/web_launch_service_impl.cc
M third_party/blink/renderer/modules/launch/web_launch_service_impl.h
M third_party/blink/renderer/modules/locked_mode/locked_mode.cc
M third_party/blink/renderer/modules/locked_mode/locked_mode.h
M third_party/blink/renderer/modules/locks/lock_manager.cc
M third_party/blink/renderer/modules/locks/lock_manager.h
M third_party/blink/renderer/modules/managed_device/navigator_managed_data.cc
M third_party/blink/renderer/modules/managed_device/navigator_managed_data.h
M third_party/blink/renderer/modules/manifest/manifest_manager.cc
M third_party/blink/renderer/modules/manifest/manifest_manager.h
M third_party/blink/renderer/modules/media/audio/audio_renderer_sink_cache.cc
M third_party/blink/renderer/modules/media_capabilities/media_capabilities.cc
M third_party/blink/renderer/modules/media_capabilities/media_capabilities.h
M third_party/blink/renderer/modules/mediasession/media_session.cc
M third_party/blink/renderer/modules/mediasession/media_session.h
M third_party/blink/renderer/modules/mediasource/source_buffer_track_base_supplement.cc
M third_party/blink/renderer/modules/mediasource/source_buffer_track_base_supplement.h
M third_party/blink/renderer/modules/mediastream/media_devices.cc
M third_party/blink/renderer/modules/mediastream/media_devices.h
M third_party/blink/renderer/modules/mediastream/media_stream_track_transfer_test.cc
M third_party/blink/renderer/modules/mediastream/user_media_client.cc
M third_party/blink/renderer/modules/mediastream/user_media_client.h
M third_party/blink/renderer/modules/ml/navigator_ml.cc
M third_party/blink/renderer/modules/ml/navigator_ml.h
M third_party/blink/renderer/modules/modules_initializer.cc
M third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
M third_party/blink/renderer/modules/mojo/mojo_file_system_access.h
M third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
M third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.h
M third_party/blink/renderer/modules/netinfo/network_information.cc
M third_party/blink/renderer/modules/netinfo/network_information.h
M third_party/blink/renderer/modules/nfc/nfc_proxy.cc
M third_party/blink/renderer/modules/nfc/nfc_proxy.h
M third_party/blink/renderer/modules/notifications/notification_manager.cc
M third_party/blink/renderer/modules/notifications/notification_manager.h
M third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
M third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.h
M third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.cc
M third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.h
M third_party/blink/renderer/modules/payments/payment_app_service_worker_registration.cc
M third_party/blink/renderer/modules/payments/payment_app_service_worker_registration.h
M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.h
M third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.cc
M third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.h
M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_controller.cc
M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_controller.h
M third_party/blink/renderer/modules/peerconnection/rtc_transport/rtc_transport_dependencies.cc
M third_party/blink/renderer/modules/peerconnection/rtc_transport/rtc_transport_dependencies.h
M third_party/blink/renderer/modules/permissions/permissions.cc
M third_party/blink/renderer/modules/permissions/permissions.h
M third_party/blink/renderer/modules/plugins/navigator_plugins.cc
M third_party/blink/renderer/modules/plugins/navigator_plugins.h
M third_party/blink/renderer/modules/presentation/presentation.cc
M third_party/blink/renderer/modules/presentation/presentation.h
M third_party/blink/renderer/modules/presentation/presentation_controller.cc
M third_party/blink/renderer/modules/presentation/presentation_controller.h
M third_party/blink/renderer/modules/printing/web_printing_manager.cc
M third_party/blink/renderer/modules/printing/web_printing_manager.h
M third_party/blink/renderer/modules/push_messaging/push_messaging_bridge.cc
M third_party/blink/renderer/modules/push_messaging/push_messaging_bridge.h
M third_party/blink/renderer/modules/push_messaging/push_messaging_client.cc
M third_party/blink/renderer/modules/push_messaging/push_messaging_client.h
M third_party/blink/renderer/modules/push_messaging/push_provider.cc
M third_party/blink/renderer/modules/push_messaging/push_provider.h
M third_party/blink/renderer/modules/push_messaging/service_worker_registration_push.cc
M third_party/blink/renderer/modules/push_messaging/service_worker_registration_push.h
M third_party/blink/renderer/modules/quota/navigator_storage_quota.cc
M third_party/blink/renderer/modules/quota/navigator_storage_quota.h
M third_party/blink/renderer/modules/remote_objects/remote_object_gateway_impl.cc
M third_party/blink/renderer/modules/remote_objects/remote_object_gateway_impl.h
M third_party/blink/renderer/modules/screen_details/window_screen_details.cc
M third_party/blink/renderer/modules/screen_details/window_screen_details.h
M third_party/blink/renderer/modules/screen_orientation/screen_orientation_controller.cc
M third_party/blink/renderer/modules/screen_orientation/screen_orientation_controller.h
M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h
M third_party/blink/renderer/modules/sensor/sensor_provider_proxy.cc
M third_party/blink/renderer/modules/sensor/sensor_provider_proxy.h
M third_party/blink/renderer/modules/serial/serial.cc
M third_party/blink/renderer/modules/serial/serial.h
M third_party/blink/renderer/modules/service_worker/service_worker_container.cc
M third_party/blink/renderer/modules/service_worker/service_worker_container.h
M third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
M third_party/blink/renderer/modules/service_worker/service_worker_registration.h
M third_party/blink/renderer/modules/shapedetection/barcode_detector_statics.cc
M third_party/blink/renderer/modules/shapedetection/barcode_detector_statics.h
M third_party/blink/renderer/modules/shared_storage/shared_storage_window_supplement.cc
M third_party/blink/renderer/modules/shared_storage/shared_storage_window_supplement.h
M third_party/blink/renderer/modules/shared_storage/shared_storage_worklet_global_scope.cc
M third_party/blink/renderer/modules/shared_storage/shared_storage_worklet_global_scope.h
M third_party/blink/renderer/modules/shared_storage/window_shared_storage.cc
M third_party/blink/renderer/modules/smart_card/smart_card_resource_manager.cc
M third_party/blink/renderer/modules/smart_card/smart_card_resource_manager.h
M third_party/blink/renderer/modules/speech/speech_recognition_controller.cc
M third_party/blink/renderer/modules/speech/speech_recognition_controller.h
M third_party/blink/renderer/modules/speech/speech_synthesis.cc
M third_party/blink/renderer/modules/speech/speech_synthesis.h
M third_party/blink/renderer/modules/storage/dom_window_storage.cc
M third_party/blink/renderer/modules/storage/dom_window_storage.h
M third_party/blink/renderer/modules/storage/dom_window_storage_controller.cc
M third_party/blink/renderer/modules/storage/dom_window_storage_controller.h
M third_party/blink/renderer/modules/storage/storage_namespace.cc
M third_party/blink/renderer/modules/storage/storage_namespace.h
M third_party/blink/renderer/modules/storage_access/document_storage_access.cc
M third_party/blink/renderer/modules/storage_access/document_storage_access.h
M third_party/blink/renderer/modules/storage_access/global_storage_access_handle.cc
M third_party/blink/renderer/modules/storage_access/global_storage_access_handle.h
M third_party/blink/renderer/modules/storage_access/storage_access_handle.cc
M third_party/blink/renderer/modules/storage_access/storage_access_handle.h
M third_party/blink/renderer/modules/subapps/sub_apps.cc
M third_party/blink/renderer/modules/subapps/sub_apps.h
M third_party/blink/renderer/modules/vibration/vibration_controller.cc
M third_party/blink/renderer/modules/vibration/vibration_controller.h
M third_party/blink/renderer/modules/virtualkeyboard/virtual_keyboard.cc
M third_party/blink/renderer/modules/virtualkeyboard/virtual_keyboard.h
M third_party/blink/renderer/modules/wake_lock/wake_lock.cc
M third_party/blink/renderer/modules/wake_lock/wake_lock.h
M third_party/blink/renderer/modules/web_install/navigator_web_install.cc
M third_party/blink/renderer/modules/web_install/navigator_web_install.h
M third_party/blink/renderer/modules/webaudio/audio_graph_tracer.cc
M third_party/blink/renderer/modules/webaudio/audio_graph_tracer.h
M third_party/blink/renderer/modules/webcodecs/background_readback.cc
M third_party/blink/renderer/modules/webcodecs/background_readback.h
M third_party/blink/renderer/modules/webcodecs/codec_pressure_manager_provider.cc
M third_party/blink/renderer/modules/webcodecs/codec_pressure_manager_provider.h
M third_party/blink/renderer/modules/webcodecs/video_frame.cc
M third_party/blink/renderer/modules/webcodecs/webcodecs_logger.cc
M third_party/blink/renderer/modules/webcodecs/webcodecs_logger.h
M third_party/blink/renderer/modules/webgpu/gpu.cc
M third_party/blink/renderer/modules/webgpu/gpu.h
M third_party/blink/renderer/modules/webmidi/navigator_web_midi.cc
M third_party/blink/renderer/modules/webmidi/navigator_web_midi.h
M third_party/blink/renderer/modules/webshare/navigator_share.cc
M third_party/blink/renderer/modules/webshare/navigator_share.h
M third_party/blink/renderer/modules/webusb/usb.cc
M third_party/blink/renderer/modules/webusb/usb.h
M third_party/blink/renderer/modules/window_controls_overlay/window_controls_overlay.cc
M third_party/blink/renderer/modules/window_controls_overlay/window_controls_overlay.h
M third_party/blink/renderer/modules/xr/xr_system.cc
M third_party/blink/renderer/modules/xr/xr_system.h
M third_party/blink/renderer/platform/mojo/mojo_binding_context.cc
M third_party/blink/renderer/platform/mojo/mojo_binding_context.h
M third_party/blink/renderer/platform/p2p/socket_dispatcher.cc
M third_party/blink/renderer/platform/p2p/socket_dispatcher.h
M third_party/blink/renderer/platform/supplementable.h

Change size: XL

Delta: 408 files changed, 973 insertions(+), 1130 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 10, 2025, 3:26:27 PM (2 days ago) Dec 10

to Steinar H Gunderson, Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, gl...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, silv...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Steinar H Gunderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 10, 2025, 3:37:41 PM (2 days ago) Dec 10

Attention needed from Steinar H Gunderson

Daniel Cheng voted Owners-Override+1

Owners-Override

Open in Gerrit

Related details

Attention is currently required from:

Steinar H Gunderson

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 11, 2025, 10:23:30 AM (yesterday) Dec 11

Attention needed from Steinar H Gunderson

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Steinar H Gunderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steinar H Gunderson (Gerrit)

unread,

Dec 11, 2025, 12:38:05 PM (yesterday) Dec 11

to Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, gl...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, silv...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steinar H Gunderson (Gerrit)

unread,

Dec 11, 2025, 1:33:45 PM (yesterday) Dec 11

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steinar H Gunderson (Gerrit)

unread,

2:24 AM (18 hours ago) 2:24 AM

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steinar H Gunderson (Gerrit)

unread,

3:22 AM (17 hours ago) 3:22 AM

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

4:36 AM (15 hours ago) 4:36 AM

to Steinar H Gunderson, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, gl...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, silv...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Revert "Make Supplementable array-based."

This reverts commit a0c6dba59914aec4a758d89508e39e0c524abad6.
(See blink-dev for background.)

Bug: 460165754

Change-Id: I91fa12fdc9d5d393ecc5b6e8896d9ec809d88827

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7246162

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Steinar H Gunderson <se...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1557920}

Files:

Change size: XL

Delta: 406 files changed, 971 insertions(+), 1127 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages