Migrate `Vector::AppendRange()` to `Append()` or `append_range()` [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Mar 5, 2026, 2:43:01 AM (2 days ago) Mar 5
to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Andrew Rayskiy, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Peter Beverloo, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, abigailbk...@google.com, alexmo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hiroshig...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yuzo+...@chromium.org
Attention needed from Dave Tapuska
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Mar 5, 2026, 10:07:25 AM (2 days ago) Mar 5
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Andrew Rayskiy, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Peter Beverloo, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, abigailbk...@google.com, alexmo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hiroshig...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yuzo+...@chromium.org
Attention needed from Daniel Cheng
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
Daniel Cheng (Gerrit)
Mar 5, 2026, 4:47:10 PM (2 days ago) Mar 5
to Daniel Cheng, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Andrew Rayskiy, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Peter Beverloo, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, abigailbk...@google.com, alexmo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hiroshig...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yuzo+...@chromium.org
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 5, 2026, 5:19:19 PM (2 days ago) Mar 5
to Daniel Cheng, Dave Tapuska, Akihiro Ota, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Andrew Rayskiy, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Peter Beverloo, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, abigailbk...@google.com, alexmo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chasej...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hiroshig...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Migrate `Vector::AppendRange()` to `Append()` or `append_range()`
Depending on the specifics of the call, uses have been migrated to:
- call the `Vector` range constructor directly
- call `append_range()` instead of decomposing into a pair of iterators,
using idiomatic container adapters as appropriate
- or directly migrated to the renamed `Append()` for code that cannot
easily use the patterns above
Bug: 487938766
Change-Id: I382211ed513dc7b08ad1aaceeb3f9b0fb57cc102
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1594963}
Files:
- M third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
- M third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
- M third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
- M third_party/blink/renderer/core/content_capture/content_capture_test.cc
- M third_party/blink/renderer/core/dom/tree_scope.cc
- M third_party/blink/renderer/core/frame/local_frame.cc
- M third_party/blink/renderer/core/html/html_element.cc
- M third_party/blink/renderer/core/inspector/inspector_contrast.cc
- M third_party/blink/renderer/core/inspector/inspector_media_agent.cc
- M third_party/blink/renderer/core/inspector/inspector_media_context_impl.cc
- M third_party/blink/renderer/core/inspector/inspector_network_agent.cc
- M third_party/blink/renderer/core/inspector/inspector_session_state.cc
- M third_party/blink/renderer/core/messaging/blink_transferable_message.cc
- M third_party/blink/renderer/core/messaging/blink_transferable_message_mojom_traits.cc
- M third_party/blink/renderer/core/origin_trials/origin_trial_context_test.cc
- M third_party/blink/renderer/core/paint/inline_paint_context.cc
- M third_party/blink/renderer/core/svg/svg_path_byte_stream_builder.cc
- M third_party/blink/renderer/modules/accessibility/ax_relation_cache.cc
- M third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
- M third_party/blink/renderer/modules/direct_sockets/tcp_writable_stream_wrapper_unittest.cc
- M third_party/blink/renderer/modules/image_downloader/image_downloader_impl.cc
- M third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
- M third_party/blink/renderer/modules/notifications/notification.cc
- M third_party/blink/renderer/modules/speech/speech_recognition.cc
- M third_party/blink/renderer/modules/webcodecs/image_decoder_external.cc
- M third_party/blink/renderer/modules/webgpu/gpu_adapter.cc
- M third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
- M third_party/blink/renderer/modules/webtransport/outgoing_stream_test.cc
- M third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
- M third_party/blink/renderer/platform/image-decoders/jxl/jxl_image_decoder.cc
- M third_party/blink/renderer/platform/mediastream/media_stream_audio_deliverer.h
- M third_party/blink/renderer/platform/network/http_parsers.cc
- M third_party/blink/renderer/platform/peerconnection/rtc_event_log_output_sink_proxy.cc
- M third_party/blink/renderer/platform/wtf/vector_test.cc
Change size: M
Delta: 34 files changed, 64 insertions(+), 95 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages