media: Restrict EncryptedOcclusionTracking to HW secure playbacks [chromium/src : main]

0 views
Skip to first unread message

Vikram Pasupathy (Gerrit)

unread,
May 28, 2026, 7:55:25 PM (4 days ago) May 28
to Sangbaek Park, Sun Yueru, Dale Curtis, Benjamin Keen, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, srirama chandra sekhar, tommyw+w...@chromium.org, eme-r...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Sangbaek Park and Sun Yueru

Vikram Pasupathy voted and added 2 comments

Votes added by Vikram Pasupathy

Commit-Queue+1

2 comments

Commit Message
Line 7, Patchset 14:[media] Restrict EncryptedOcclusionTracking to HW secure playbacks
Sangbaek Park . resolved

optional nit: `media:`?

Vikram Pasupathy

Done, Thx

File third_party/blink/renderer/core/html/media/html_video_element.cc
Line 482, Patchset 14: if (!cdm_config.use_hw_secure_codecs &&
Sangbaek Park . unresolved

nit: `use_hw_secure_codecs` might be true for CrOs L1? Should we guard by `BUILD_FLAG(IS_WIN)`?

Vikram Pasupathy

The `kEncryptedMediaOcclusionTracking` feature flag is rolled out by `Win`, and then at 100% roll out, I'll make the feature flag only enabled by default for `Win`

Open in Gerrit

Related details

Attention is currently required from:
  • Sangbaek Park
  • Sun Yueru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1fb8621b432107ee65c3aa996996231a93a8d07e
Gerrit-Change-Number: 7856371
Gerrit-PatchSet: 15
Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Sangbaek Park <sangba...@chromium.org>
Gerrit-Attention: Sun Yueru <yr...@chromium.org>
Gerrit-Comment-Date: Thu, 28 May 2026 23:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sangbaek Park <sangba...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Sangbaek Park (Gerrit)

unread,
May 28, 2026, 7:58:06 PM (4 days ago) May 28
to Vikram Pasupathy, Sun Yueru, Dale Curtis, Benjamin Keen, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, srirama chandra sekhar, tommyw+w...@chromium.org, eme-r...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Sun Yueru and Vikram Pasupathy

Sangbaek Park voted and added 1 comment

Votes added by Sangbaek Park

Code-Review+1

1 comment

File third_party/blink/renderer/core/html/media/html_video_element.cc
Line 482, Patchset 14: if (!cdm_config.use_hw_secure_codecs &&
Sangbaek Park . resolved

nit: `use_hw_secure_codecs` might be true for CrOs L1? Should we guard by `BUILD_FLAG(IS_WIN)`?

Vikram Pasupathy

The `kEncryptedMediaOcclusionTracking` feature flag is rolled out by `Win`, and then at 100% roll out, I'll make the feature flag only enabled by default for `Win`

Sangbaek Park

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Sun Yueru
  • Vikram Pasupathy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fb8621b432107ee65c3aa996996231a93a8d07e
    Gerrit-Change-Number: 7856371
    Gerrit-PatchSet: 15
    Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Sun Yueru <yr...@chromium.org>
    Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 May 2026 23:57:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Sangbaek Park <sangba...@chromium.org>
    Comment-In-Reply-To: Vikram Pasupathy <vpasu...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sun Yueru (Gerrit)

    unread,
    May 29, 2026, 7:00:08 PM (3 days ago) May 29
    to Vikram Pasupathy, Sangbaek Park, Dale Curtis, Benjamin Keen, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, srirama chandra sekhar, tommyw+w...@chromium.org, eme-r...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Vikram Pasupathy

    Sun Yueru voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vikram Pasupathy
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fb8621b432107ee65c3aa996996231a93a8d07e
    Gerrit-Change-Number: 7856371
    Gerrit-PatchSet: 15
    Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 May 2026 22:59:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Vikram Pasupathy (Gerrit)

    unread,
    May 29, 2026, 8:46:57 PM (3 days ago) May 29
    to Sun Yueru, Sangbaek Park, Dale Curtis, Benjamin Keen, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, srirama chandra sekhar, tommyw+w...@chromium.org, eme-r...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

    Vikram Pasupathy voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Sat, 30 May 2026 00:46:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 29, 2026, 10:11:58 PM (3 days ago) May 29
    to Vikram Pasupathy, Sun Yueru, Sangbaek Park, Dale Curtis, Benjamin Keen, Rijubrata Bhaumik, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, srirama chandra sekhar, tommyw+w...@chromium.org, eme-r...@chromium.org, chfreme...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    media: Restrict EncryptedOcclusionTracking to HW secure playbacks

    Instantiating MediaVideoVisibilityTracker in OnEncryptedMediaInitData()
    occurred before CDM capabilities were known, causing costly occlusion
    tracking calculations to run for software DRM playbacks.

    Now, OnCdmAttached() in WebMediaPlayerClient allows HTMLVideoElement to
    check `cdm_config.use_hw_secure_codecs` before creating the tracker.
    Bug: b:498652735
    Change-Id: I1fb8621b432107ee65c3aa996996231a93a8d07e
    Reviewed-by: Sun Yueru <yr...@chromium.org>
    Reviewed-by: Sangbaek Park <sangba...@chromium.org>
    Reviewed-by: Dale Curtis <dalec...@chromium.org>
    Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1638913}
    Files:
    • M third_party/blink/renderer/core/html/media/DEPS
    • M third_party/blink/renderer/core/html/media/html_media_element.h
    • M third_party/blink/renderer/core/html/media/html_video_element.cc
    • M third_party/blink/renderer/core/html/media/html_video_element.h
    • M third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.cc
    • M third_party/blink/renderer/platform/media/media_player_client.h
    • M third_party/blink/renderer/platform/media/web_media_player_impl.cc
    • M tools/metrics/ukm/ukm.xml
    Change size: S
    Delta: 8 files changed, 27 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dale Curtis, +1 by Sun Yueru, +1 by Sangbaek Park
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I1fb8621b432107ee65c3aa996996231a93a8d07e 
    

     Gerrit-Change-Number: 7856371 
    

     Gerrit-PatchSet: 16 
    

     Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org> 
    

     Gerrit-Reviewer: Benjamin Keen <bk...@google.com> 
    

     Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
    

     Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org> 
    

     Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org> 
    

     Gerrit-Reviewer: Sun Yueru <yr...@chromium.org> 
    

     Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org> 
    

    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages