Allow author stylesheets to use UA @keyframes for view transitions [chromium/src : main]

0 views
Skip to first unread message

Hyowon Kim (Gerrit)

unread,
Mar 31, 2026, 8:35:28 PM (2 days ago) Mar 31
to Olga Gerchikov, AyeAye, Kevin Ellis, Vladimir Levin, Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Ellis, Robert Flack and Vladimir Levin

Hyowon Kim added 1 comment

File third_party/blink/renderer/core/css/resolver/style_resolver.cc
Line 2715, Patchset 1: kPseudoIdViewTransition);
Robert Flack . unresolved

I suspect unmatched keyframe names is going to be a common occurrence. I think we should just move the keyframe rules to html.css. This way we don't need to load the entire view transition stylesheet css unless/until view transitions are actually used. Adding @vmp...@chromium.org to confirm.

Vladimir Levin

Yeah, I agree we should move as much of this as possible to html.css

@kev...@chromium.org who has done some of this work already.

Hyowon Kim

Moved the three @keyframes rules to html.css and removed them from transition.css. Please take another look.

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
  • Robert Flack
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1aec849a2860f27d46a89d4143ec489e065ed912
Gerrit-Change-Number: 7699178
Gerrit-PatchSet: 5
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Kevin Ellis <kev...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 00:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Flack <fla...@chromium.org>
Comment-In-Reply-To: Vladimir Levin <vmp...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Ellis (Gerrit)

unread,
Apr 1, 2026, 9:06:39 AM (21 hours ago) Apr 1
to Hyowon Kim, Olga Gerchikov, AyeAye, Vladimir Levin, Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Hyowon Kim, Robert Flack and Vladimir Levin

Kevin Ellis voted and added 1 comment

Votes added by Kevin Ellis

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
  • Robert Flack
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1aec849a2860f27d46a89d4143ec489e065ed912
Gerrit-Change-Number: 7699178
Gerrit-PatchSet: 5
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 13:06:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Apr 1, 2026, 10:38:01 AM (20 hours ago) Apr 1
to Hyowon Kim, Kevin Ellis, Olga Gerchikov, AyeAye, Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Hyowon Kim and Robert Flack

Vladimir Levin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
  • Robert Flack
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:37:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Flack (Gerrit)

unread,
Apr 1, 2026, 11:10:51 AM (19 hours ago) Apr 1
to Hyowon Kim, Vladimir Levin, Kevin Ellis, Olga Gerchikov, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Hyowon Kim

Robert Flack voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
Gerrit-Comment-Date: Wed, 01 Apr 2026 15:10:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hyowon Kim (Gerrit)

unread,
Apr 1, 2026, 8:06:53 PM (10 hours ago) Apr 1
to Robert Flack, Vladimir Levin, Kevin Ellis, Olga Gerchikov, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Hyowon Kim added 1 comment

File third_party/blink/renderer/core/css/resolver/style_resolver.cc
Line 2715, Patchset 1: kPseudoIdViewTransition);
Robert Flack . resolved

I suspect unmatched keyframe names is going to be a common occurrence. I think we should just move the keyframe rules to html.css. This way we don't need to load the entire view transition stylesheet css unless/until view transitions are actually used. Adding @vmp...@chromium.org to confirm.

Vladimir Levin

Yeah, I agree we should move as much of this as possible to html.css

@kev...@chromium.org who has done some of this work already.

Hyowon Kim

Moved the three @keyframes rules to html.css and removed them from transition.css. Please take another look.

Hyowon Kim

Done. Thanks.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1aec849a2860f27d46a89d4143ec489e065ed912
    Gerrit-Change-Number: 7699178
    Gerrit-PatchSet: 5
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:06:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hyowon Kim <hyo...@igalia.com>
    satisfied_requirement
    open
    diffy

    Hyowon Kim (Gerrit)

    unread,
    Apr 1, 2026, 8:06:55 PM (10 hours ago) Apr 1
    to Robert Flack, Vladimir Levin, Kevin Ellis, Olga Gerchikov, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    Hyowon Kim voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:06:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 11:08:10 PM (7 hours ago) Apr 1
    to Hyowon Kim, Robert Flack, Vladimir Levin, Kevin Ellis, Olga Gerchikov, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Allow author stylesheets to use UA @keyframes for view transitions

    UA @keyframes like -ua-view-transition-fade-out were defined in
    `DefaultPseudoElementStyle`, which is only searched for pseudo-elements.
    Move them to html.css so they are always available to regular elements.
    Bug: 396813145
    Change-Id: I1aec849a2860f27d46a89d4143ec489e065ed912
    Commit-Queue: Hyowon Kim <hyo...@igalia.com>
    Reviewed-by: Kevin Ellis <kev...@chromium.org>
    Reviewed-by: Vladimir Levin <vmp...@chromium.org>
    Reviewed-by: Robert Flack <fla...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1608935}
    Files:
    • M third_party/blink/renderer/core/css/transition.css
    • M third_party/blink/renderer/core/html/resources/html.css
    • M third_party/blink/web_tests/TestExpectations
    Change size: S
    Delta: 3 files changed, 13 insertions(+), 20 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Robert Flack, +1 by Kevin Ellis, +1 by Vladimir Levin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1aec849a2860f27d46a89d4143ec489e065ed912
    Gerrit-Change-Number: 7699178
    Gerrit-PatchSet: 6
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages