ContainerTiming: reduce WPT waits in buffering cases [chromium/src : main]
0 views
Skip to first unread message
José Dapena Paz (Gerrit)
May 28, 2025, 12:03:22 PMMay 28
to chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org
José Dapena Paz has uploaded the change for review![]( "Open in Gerrit")
Commit message
ContainerTiming: reduce WPT waits in buffering cases
In the buffering test cases we were using step_timeout to wait first to set up
the paint before setting the observer, then to actual check if a paint was
observed. Instead of this, use the elementtiming wait as in other tests, and
only wait 1 second in the second buffering disabled case.
Bug: 382422286
Change-Id: Ib903f7a24253848189fb241c8143e73518783a59
Change diff
Change information
Files:
- M third_party/blink/web_tests/external/wpt/container-timing/resources/container-timing-helpers.js
- M third_party/blink/web_tests/external/wpt/container-timing/tentative/containertiming-observe-after-paint-with-buffering.html
- M third_party/blink/web_tests/external/wpt/container-timing/tentative/containertiming-observe-after-paint-without-buffering.html
Change size: S
Delta: 3 files changed, 22 insertions(+), 14 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Sep 15, 2025, 9:33:47 AM (4 days ago) Sep 15
to José Dapena Paz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from José Dapena Paz
Michal Mocny added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Michal Mocny . resolved
I think this okay, but has a merge conflict. Waiting for rebase in case the previous patches changed.
Related details
Attention is currently required from:
- José Dapena Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Dapena Paz (Gerrit)
Sep 15, 2025, 12:37:11 PM (4 days ago) Sep 15
to Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
José Dapena Paz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 12 (Latest):
José Dapena Paz . resolved
Merge conflict seems to be gone now.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Sep 15, 2025, 1:37:28 PM (4 days ago) Sep 15
to José Dapena Paz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from José Dapena Paz
Michal Mocny voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michal Mocny
| Code-Review | +1 |
2 comments
Patchset-level comments
Michal Mocny . resolved
Added one concern but it doesn't need to block the patch. I think this is an improvement either way.
File third_party/blink/web_tests/external/wpt/container-timing/tentative/containertiming-observe-after-paint-with-buffering.html
Line 33, Patchset 12 (Latest):
img.src = '/container-timing/resources/square100.png';Michal Mocny . unresolved
Nit: is this `src` path required to be the same as the one used in `addPaintingElementTimingAfterDoubleRAF` or is it just coinidence?
It seems to me that you are racing the network fetch of the container timing and element timing elements, and the race is (mostly?) resolved because they use the same resource.
Related details
Attention is currently required from:
- José Dapena Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages