Improve option list for select.selectedOptions [chromium/src : main]
0 views
Skip to first unread message
Joey Arhar (Gerrit)
Oct 15, 2025, 4:23:05 PM (4 days ago) Oct 15
to AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org
Joey Arhar voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
Oct 16, 2025, 8:30:58 AM (3 days ago) Oct 16
to AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar
Dominic Farolino added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dominic Farolino . resolved
Shouldn't we be removing some expectations from third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/select-selectedOptions-nesting.window-expected.txt?
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Oct 16, 2025, 10:16:01 PM (3 days ago) Oct 16
to Dominic Farolino, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Dominic Farolino
Joey Arhar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominic Farolino . resolved
Shouldn't we be removing some expectations from third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/select-selectedOptions-nesting.window-expected.txt?
Joey Arhar
Done. It wasn't removed when I first uploaded it because the WPT wasn't merged yet and/or the WPT importer hadn't run yet.
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
Oct 17, 2025, 9:45:22 AM (2 days ago) Oct 17
to AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar
Dominic Farolino voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Oct 17, 2025, 12:55:54 PM (2 days ago) Oct 17
to Dominic Farolino, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Joey Arhar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 17, 2025, 1:02:54 PM (2 days ago) Oct 17
to Dominic Farolino, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Improve option list for select.selectedOptions
This patch makes the selectedOptions collection make sure that the
options it includes are actually associated with the correct select
element. Tests are here:
https://github.com/web-platform-tests/wpt/pull/55424
Change-Id: I3736322eae41bdb530337d5c5b2bef932ad0c049
Reviewed-by: Dominic Farolino <d...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531516}
Files:
- M third_party/blink/renderer/core/html/html_collection.cc
- D third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/select-selectedOptions-nesting.window-expected.txt
Change size: S
Delta: 2 files changed, 4 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Farolino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages