Explicit inline hot functions in fast-path parser [chromium/src : main]

0 views
Skip to first unread message

Bin Liao (Gerrit)

unread,
Feb 21, 2023, 12:37:12 AMFeb 21
to Scott Violet, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention is currently required from: Scott Violet.

Bin Liao would like Scott Violet to review this change.

View Change

Explicit inline hot functions in fast-path parser

The functions are:
IsWhitespace, IsValidUnquotedAttributeValueChar, IsValidAttributeNameChar
IsCharAfterTagnameOrAttribute, IsCharAfterUnquotedAttribute

Bug: 1407201
Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
---
M third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc b/third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
index c8ab7e1..75258b2 100644
--- a/third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
+++ b/third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
@@ -438,7 +438,7 @@

// Match ASCII Whitespace according to
// https://infra.spec.whatwg.org/#ascii-whitespace
- bool IsWhitespace(Char c) {
+ ALWAYS_INLINE bool IsWhitespace(Char c) {
switch (c) {
case ' ':
case '\t':
@@ -451,13 +451,13 @@
}
}

- bool IsValidUnquotedAttributeValueChar(Char c) {
+ ALWAYS_INLINE bool IsValidUnquotedAttributeValueChar(Char c) {
return ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z') ||
('0' <= c && c <= '9') || c == '_' || c == '-';
}

// https://html.spec.whatwg.org/#syntax-attribute-name
- bool IsValidAttributeNameChar(Char c) {
+ ALWAYS_INLINE bool IsValidAttributeNameChar(Char c) {
if (c == '=') {
// Early exit for the most common way to end an attribute.
return false;
@@ -466,11 +466,11 @@
('0' <= c && c <= '9');
}

- bool IsCharAfterTagnameOrAttribute(Char c) {
+ ALWAYS_INLINE bool IsCharAfterTagnameOrAttribute(Char c) {
return c == ' ' || c == '>' || IsWhitespace(c) || c == '/';
}

- bool IsCharAfterUnquotedAttribute(Char c) {
+ ALWAYS_INLINE bool IsCharAfterUnquotedAttribute(Char c) {
return c == ' ' || c == '>' || IsWhitespace(c);
}


To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
Gerrit-Change-Number: 4272280
Gerrit-PatchSet: 2
Gerrit-Owner: Bin Liao <bin....@intel.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-MessageType: newchange

Bin Liao (Gerrit)

unread,
Feb 21, 2023, 12:37:18 AMFeb 21
to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Scott Violet, Tricium, chromium...@chromium.org

Attention is currently required from: Scott Violet.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      Hi Scott,
      I have studied the fast-path parser related code these days, it's really a good progression for Speedometer, this CL is used to explicit inline some hot functions in fast-path parser for the PGO may not inline them. Would you help to review this patch? Thank you.

To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
Gerrit-Change-Number: 4272280
Gerrit-PatchSet: 2
Gerrit-Owner: Bin Liao <bin....@intel.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 05:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Daniel Cheng (Gerrit)

unread,
Feb 21, 2023, 12:50:12 AMFeb 21
to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

Attention is currently required from: Scott Violet.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      question for sky: isn't this the sort of thing PGO is supposed to help with?

To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
Gerrit-Change-Number: 4272280
Gerrit-PatchSet: 2
Gerrit-Owner: Bin Liao <bin....@intel.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 05:50:05 +0000

Scott Violet (Gerrit)

unread,
Feb 21, 2023, 11:54:25 AMFeb 21
to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

Attention is currently required from: Bin Liao, Daniel Cheng.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      question for sky: isn't this the sort of thing PGO is supposed to help with?

    • Yes, but then I don't know enough of the specifics as to exactly what pgo ends up inlining.

      Bin, did you measure an impact with this change? I don't see any pinpoint runs.

To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
Gerrit-Change-Number: 4272280
Gerrit-PatchSet: 2
Gerrit-Owner: Bin Liao <bin....@intel.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Bin Liao <bin....@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 16:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
Gerrit-MessageType: comment

Daniel Cheng (Gerrit)

unread,
Feb 21, 2023, 7:53:58 PMFeb 21
to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

Attention is currently required from: Bin Liao.

View Change

1 comment:

  • Patchset:

    • Patch Set #2:

      Yes, but then I don't know enough of the specifics as to exactly what pgo ends up inlining. […]

      Ack. Sadness :(

To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
Gerrit-Change-Number: 4272280
Gerrit-PatchSet: 2
Gerrit-Owner: Bin Liao <bin....@intel.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Bin Liao <bin....@intel.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 00:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
Comment-In-Reply-To: Scott Violet <s...@chromium.org>
Gerrit-MessageType: comment

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 22, 2023, 11:44:54 PMFeb 22
to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

Attention is currently required from: Bin Liao.

📍 Job complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/173dc690fa0000

View Change

    To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
    Gerrit-Change-Number: 4272280
    Gerrit-PatchSet: 2
    Gerrit-Owner: Bin Liao <bin....@intel.com>
    Gerrit-Reviewer: Scott Violet <s...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Bin Liao <bin....@intel.com>
    Gerrit-Comment-Date: Thu, 23 Feb 2023 04:44:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    chromeperf@appspot.gserviceaccount.com (Gerrit)

    unread,
    Feb 23, 2023, 1:05:23 AMFeb 23
    to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

    Attention is currently required from: Bin Liao.

    📍 Job complete.

    See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1590df12fa0000

    View Change

      To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      Gerrit-Change-Number: 4272280
      Gerrit-PatchSet: 2
      Gerrit-Owner: Bin Liao <bin....@intel.com>
      Gerrit-Reviewer: Scott Violet <s...@chromium.org>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Bin Liao <bin....@intel.com>
      Gerrit-Comment-Date: Thu, 23 Feb 2023 06:05:16 +0000

      Bin Liao (Gerrit)

      unread,
      Feb 23, 2023, 10:49:31 AMFeb 23
      to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, chrom...@appspot.gserviceaccount.com, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

      View Change

      1 comment:

      • Patchset:

        • Patch Set #2:

          Hi Scott,
          I have ran pinpoint test both for win-10-perf and win-10-perf-pgo, the pgo result shows a 0.2% progression but the non-pgo shows a regression, maybe it was variance?
          Btw, I am not sure whether the fastpath parser feature is default enabled in the pinpoint dev. I think add always_inline is friendly for performance as the pgo sometimes may not inline it.

      To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      Gerrit-Change-Number: 4272280
      Gerrit-PatchSet: 2
      Gerrit-Owner: Bin Liao <bin....@intel.com>
      Gerrit-Reviewer: Scott Violet <s...@chromium.org>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Thu, 23 Feb 2023 15:49:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Gerrit-MessageType: comment

      Scott Violet (Gerrit)

      unread,
      Feb 23, 2023, 7:52:47 PMFeb 23
      to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, chrom...@appspot.gserviceaccount.com, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

      Attention is currently required from: Bin Liao.

      View Change

      1 comment:

      • Patchset:

        • Patch Set #2:

          Hi Scott, […]

          To Daniel's question, it would be good to know if this actually makes a difference. When building a pgo build, does this change result in a different binary?

      To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      Gerrit-Change-Number: 4272280
      Gerrit-PatchSet: 2
      Gerrit-Owner: Bin Liao <bin....@intel.com>
      Gerrit-Reviewer: Scott Violet <s...@chromium.org>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Bin Liao <bin....@intel.com>
      Gerrit-Comment-Date: Fri, 24 Feb 2023 00:52:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Bin Liao <bin....@intel.com>
      Gerrit-MessageType: comment

      Bin Liao (Gerrit)

      unread,
      Feb 28, 2023, 2:43:36 AMFeb 28
      to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, chrom...@appspot.gserviceaccount.com, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

      Attention is currently required from: Scott Violet.

      View Change

      1 comment:

      • Patchset:

        • Patch Set #2:

          To Daniel's question, it would be good to know if this actually makes a difference. […]

          Thanks Scott, I have verified this on linux platform by using llvm-nm tool to analyze libcore_hot.a and found that "IsWhitespace, IsValidUnquotedAttributeValueChar, IsValidAttributeNameChar
          IsCharAfterTagnameOrAttribute, IsCharAfterUnquotedAttribute" have been inlined,
          however, function ParseElementAfterTagname is not inlined which is also very hot. So I will update the patch set to inline ParseElementAfterTagname.

      To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      Gerrit-Change-Number: 4272280
      Gerrit-PatchSet: 2
      Gerrit-Owner: Bin Liao <bin....@intel.com>
      Gerrit-Reviewer: Scott Violet <s...@chromium.org>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Scott Violet <s...@chromium.org>
      Gerrit-Comment-Date: Tue, 28 Feb 2023 07:43:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Bin Liao <bin....@intel.com>

      Bin Liao (Gerrit)

      unread,
      Feb 28, 2023, 10:39:56 PMFeb 28
      to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

      Attention is currently required from: Scott Violet.

      Bin Liao uploaded patch set #7 to this change.

      View Change

      Explicit inline hot functions in fast-path parser

      The ParseElementAfterTagname and ParseSpecificElements are hot functions in fast-path parser, however, both are not inlined by llvm and PGO, so explicit inline them here.


      Bug: 1407201
      Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      ---
      M third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
      1 file changed, 3 insertions(+), 3 deletions(-)

      To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
      Gerrit-Change-Number: 4272280
      Gerrit-PatchSet: 7
      Gerrit-Owner: Bin Liao <bin....@intel.com>
      Gerrit-Reviewer: Scott Violet <s...@chromium.org>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Scott Violet <s...@chromium.org>
      Gerrit-MessageType: newpatchset

      chromeperf@appspot.gserviceaccount.com (Gerrit)

      unread,
      Mar 1, 2023, 3:55:19 AMMar 1
      to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

      Attention is currently required from: Bin Liao, Scott Violet.

      😿 Job failed.

      See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17eba270fa0000

      View Change

        To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
        Gerrit-Change-Number: 4272280
        Gerrit-PatchSet: 7
        Gerrit-Owner: Bin Liao <bin....@intel.com>
        Gerrit-Reviewer: Scott Violet <s...@chromium.org>
        Gerrit-CC: Daniel Cheng <dch...@chromium.org>
        Gerrit-Attention: Bin Liao <bin....@intel.com>
        Gerrit-Attention: Scott Violet <s...@chromium.org>
        Gerrit-Comment-Date: Wed, 01 Mar 2023 08:55:12 +0000

        chromeperf@appspot.gserviceaccount.com (Gerrit)

        unread,
        Mar 1, 2023, 6:03:55 AMMar 1
        to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

        Attention is currently required from: Bin Liao, Scott Violet.

        📍 Job complete.

        See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10085e18fa0000

        View Change

          To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
          Gerrit-Change-Number: 4272280
          Gerrit-PatchSet: 7
          Gerrit-Owner: Bin Liao <bin....@intel.com>
          Gerrit-Reviewer: Scott Violet <s...@chromium.org>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-Attention: Bin Liao <bin....@intel.com>
          Gerrit-Attention: Scott Violet <s...@chromium.org>
          Gerrit-Comment-Date: Wed, 01 Mar 2023 11:03:47 +0000

          chromeperf@appspot.gserviceaccount.com (Gerrit)

          unread,
          Mar 1, 2023, 7:14:22 AMMar 1
          to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

          Attention is currently required from: Bin Liao, Scott Violet.

          📍 Job complete.

          See results at: https://pinpoint-dot-chromeperf.appspot.com/job/140a53e8fa0000

          View Change

            To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
            Gerrit-Change-Number: 4272280
            Gerrit-PatchSet: 7
            Gerrit-Owner: Bin Liao <bin....@intel.com>
            Gerrit-Reviewer: Scott Violet <s...@chromium.org>
            Gerrit-CC: Daniel Cheng <dch...@chromium.org>
            Gerrit-Attention: Bin Liao <bin....@intel.com>
            Gerrit-Attention: Scott Violet <s...@chromium.org>
            Gerrit-Comment-Date: Wed, 01 Mar 2023 12:14:15 +0000

            Bin Liao (Gerrit)

            unread,
            Mar 2, 2023, 7:41:39 PMMar 2
            to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, chrom...@appspot.gserviceaccount.com, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

            Attention is currently required from: Scott Violet.

            View Change

            1 comment:

            • Patchset:

              • Patch Set #2:

                Yeah, I have built the chrome with pgo, and it was a official build, not component build, Another fu […]

                Done

            To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
            Gerrit-Change-Number: 4272280
            Gerrit-PatchSet: 7
            Gerrit-Owner: Bin Liao <bin....@intel.com>
            Gerrit-Reviewer: Scott Violet <s...@chromium.org>
            Gerrit-CC: Daniel Cheng <dch...@chromium.org>
            Gerrit-Attention: Scott Violet <s...@chromium.org>
            Gerrit-Comment-Date: Fri, 03 Mar 2023 00:41:28 +0000

            Bin Liao (Gerrit)

            unread,
            Mar 5, 2023, 8:35:12 PMMar 5
            to blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, chrom...@appspot.gserviceaccount.com, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

            Attention is currently required from: Scott Violet.

            View Change

            1 comment:

            • Patchset:

              • Patch Set #7:

                Hi, Scott, Could you help to review whether this CL is useful? Thanks.

            To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
            Gerrit-Change-Number: 4272280
            Gerrit-PatchSet: 7
            Gerrit-Owner: Bin Liao <bin....@intel.com>
            Gerrit-Reviewer: Scott Violet <s...@chromium.org>
            Gerrit-CC: Daniel Cheng <dch...@chromium.org>
            Gerrit-Attention: Scott Violet <s...@chromium.org>
            Gerrit-Comment-Date: Mon, 06 Mar 2023 01:34:54 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Gerrit-MessageType: comment

            chromeperf@appspot.gserviceaccount.com (Gerrit)

            unread,
            Mar 21, 2023, 3:10:55 AMMar 21
            to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

            Attention is currently required from: Bin Liao, Scott Violet.

            📍 Job complete.

            See results at: https://pinpoint-dot-chromeperf.appspot.com/job/171b2380860000

            View Change

              To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
              Gerrit-Change-Number: 4272280
              Gerrit-PatchSet: 7
              Gerrit-Owner: Bin Liao <bin....@intel.com>
              Gerrit-Reviewer: Scott Violet <s...@chromium.org>
              Gerrit-CC: Daniel Cheng <dch...@chromium.org>
              Gerrit-Attention: Bin Liao <bin....@intel.com>
              Gerrit-Attention: Scott Violet <s...@chromium.org>
              Gerrit-Comment-Date: Tue, 21 Mar 2023 07:10:47 +0000

              chromeperf@appspot.gserviceaccount.com (Gerrit)

              unread,
              Mar 21, 2023, 3:27:54 AMMar 21
              to Bin Liao, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Daniel Cheng, Scott Violet, Tricium, chromium...@chromium.org

              Attention is currently required from: Bin Liao, Scott Violet.

              📍 Job complete.

              See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1759092b060000

              View Change

                To view, visit change 4272280. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I61e8d4df185e6c9b2961e33cc87c66cf1487918e
                Gerrit-Change-Number: 4272280
                Gerrit-PatchSet: 7
                Gerrit-Owner: Bin Liao <bin....@intel.com>
                Gerrit-Reviewer: Scott Violet <s...@chromium.org>
                Gerrit-CC: Daniel Cheng <dch...@chromium.org>
                Gerrit-Attention: Bin Liao <bin....@intel.com>
                Gerrit-Attention: Scott Violet <s...@chromium.org>
                Gerrit-Comment-Date: Tue, 21 Mar 2023 07:27:42 +0000
                Reply all
                Reply to author
                Forward
                0 new messages