Update SSLClientSessionCache to handle stateful memory pressure [chromium/src : main]

0 views
Skip to first unread message

Patrick Monette (Gerrit)

unread,
Dec 5, 2025, 5:10:15 PM (14 days ago) Dec 5
to Chromium Metrics Reviews, Menard, Alexis, Mangesh Ghiware, Sophie Chang, Lei Zhang, Stephen Chenney, Mark Schillaci, Dirk Schulze, (Julie)Jeongeun Kim, Heron Yang, AyeAye, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, vakh+safe_br...@chromium.org, drott+bl...@chromium.org, dullweb...@chromium.org, hanxi...@chromium.org, sloboda...@chromium.org, omnibox-...@chromium.org, dtseng...@chromium.org, ayman...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, twelling...@chromium.org, nwoked...@chromium.org, apavlo...@chromium.org, mattsimm...@chromium.org, vasilii+watchlis...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, christia...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org, yusufo...@chromium.org, fmalit...@chromium.org, derinel+wat...@google.com, yuzo+...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, devtools...@chromium.org, andysjl...@chromium.org, gcasto+w...@chromium.org, dewitt...@chromium.org, thegreenf...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, blink-reviews-p...@chromium.org, peilinwa...@google.com, blink-rev...@chromium.org, ender...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, language...@chromium.org, trewin...@google.com, penghuan...@chromium.org, extension...@chromium.org, lwinston+watc...@google.com, srahim...@chromium.org, josiah...@chromium.org, ios-revie...@chromium.org, mac-r...@chromium.org, dtapuska+...@chromium.org, blink-...@chromium.org, davidj...@chromium.org, yuezhang...@chromium.org, jmedle...@chromium.org, wychen...@chromium.org, blink-re...@chromium.org, agriev...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, asvitki...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, zackha...@chromium.org, donnd...@chromium.org, filesapp...@chromium.org, gangwu...@chromium.org, jdeblas...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, android-web...@chromium.org, jatapiaro+wat...@google.com, browser-comp...@chromium.org, xinghui...@chromium.org, gogeral...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, fserb...@chromium.org, drott...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller

Patrick Monette added 3 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Patrick Monette . resolved

Thanks for the review. You uncovered a major issue.

PTAnL

File base/memory/memory_pressure_listener_registry.cc
Line 154, Patchset 4: run_loop.Run();
Matt Mueller . resolved

This method is named as being async no longer async if it's running a loop to wait for the task to have finished

Patrick Monette

Good point. The name is mostly to mean that it's to be used for async memory pressure listeners, but I agree that it doesn't feel right. I ended up with another version in https://chromium-review.googlesource.com/c/chromium/src/+/7229564 where the function is truly async, but you can pass the QuitClosure as a parameter so the synchronous part is done by the calling code.

File net/ssl/ssl_client_session_cache.cc
Line 219, Patchset 4: cache_.UpdateMaxSize(0);
Matt Mueller . resolved

Does this actually work? The unittest does not actually test what happens when you try to insert an element after setting the max to zero. lru_cache special cases 0 as NO_AUTO_EVICT, meaning it no longer manages the size at all. (And if it didn't special case 0, it would cause an overflow at the line it does ` ShrinkToSize(max_size_ - 1);`)

Patrick Monette

Yeah I missed a big issue here. Thanks!

I needed more changes to LRUCache which I did in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/7228584.

I also added a test to ensure inserting an element fails when the max is zero.

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I487235195a8ac60f978d3fa34fb8198c806e3610
Gerrit-Change-Number: 7224452
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 22:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Mueller <ma...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
Dec 5, 2025, 10:31:31 PM (13 days ago) Dec 5
to Chromium Metrics Reviews, Menard, Alexis, Mangesh Ghiware, Sophie Chang, Lei Zhang, Stephen Chenney, Mark Schillaci, Dirk Schulze, (Julie)Jeongeun Kim, Heron Yang, AyeAye, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, vakh+safe_br...@chromium.org, drott+bl...@chromium.org, dullweb...@chromium.org, hanxi...@chromium.org, sloboda...@chromium.org, omnibox-...@chromium.org, dtseng...@chromium.org, ayman...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, twelling...@chromium.org, nwoked...@chromium.org, apavlo...@chromium.org, mattsimm...@chromium.org, vasilii+watchlis...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, christia...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org, yusufo...@chromium.org, fmalit...@chromium.org, derinel+wat...@google.com, yuzo+...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, devtools...@chromium.org, andysjl...@chromium.org, gcasto+w...@chromium.org, dewitt...@chromium.org, thegreenf...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, blink-reviews-p...@chromium.org, peilinwa...@google.com, blink-rev...@chromium.org, ender...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, language...@chromium.org, trewin...@google.com, penghuan...@chromium.org, extension...@chromium.org, lwinston+watc...@google.com, srahim...@chromium.org, josiah...@chromium.org, ios-revie...@chromium.org, mac-r...@chromium.org, dtapuska+...@chromium.org, blink-...@chromium.org, davidj...@chromium.org, yuezhang...@chromium.org, jmedle...@chromium.org, wychen...@chromium.org, blink-re...@chromium.org, agriev...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, asvitki...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, zackha...@chromium.org, donnd...@chromium.org, filesapp...@chromium.org, gangwu...@chromium.org, jdeblas...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, android-web...@chromium.org, jatapiaro+wat...@google.com, browser-comp...@chromium.org, xinghui...@chromium.org, gogeral...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, fserb...@chromium.org, drott...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller

Patrick Monette added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Patrick Monette . resolved

Unfortunately a bad rebase added a bunch of bots that keep failing, but the CQ passes.

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I487235195a8ac60f978d3fa34fb8198c806e3610
Gerrit-Change-Number: 7224452
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Sat, 06 Dec 2025 03:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Matt Mueller (Gerrit)

unread,
Dec 8, 2025, 3:03:14 PM (11 days ago) Dec 8
to Patrick Monette, Matt Mueller, Chromium Metrics Reviews, Menard, Alexis, Mangesh Ghiware, Sophie Chang, Lei Zhang, Stephen Chenney, Mark Schillaci, Dirk Schulze, (Julie)Jeongeun Kim, Heron Yang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, vakh+safe_br...@chromium.org, drott+bl...@chromium.org, dullweb...@chromium.org, hanxi...@chromium.org, sloboda...@chromium.org, omnibox-...@chromium.org, dtseng...@chromium.org, ayman...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, twelling...@chromium.org, nwoked...@chromium.org, apavlo...@chromium.org, mattsimm...@chromium.org, vasilii+watchlis...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, christia...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org, yusufo...@chromium.org, fmalit...@chromium.org, derinel+wat...@google.com, yuzo+...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, devtools...@chromium.org, andysjl...@chromium.org, gcasto+w...@chromium.org, dewitt...@chromium.org, thegreenf...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, blink-reviews-p...@chromium.org, peilinwa...@google.com, blink-rev...@chromium.org, ender...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, language...@chromium.org, trewin...@google.com, penghuan...@chromium.org, extension...@chromium.org, lwinston+watc...@google.com, srahim...@chromium.org, josiah...@chromium.org, ios-revie...@chromium.org, mac-r...@chromium.org, dtapuska+...@chromium.org, blink-...@chromium.org, davidj...@chromium.org, yuezhang...@chromium.org, jmedle...@chromium.org, wychen...@chromium.org, blink-re...@chromium.org, agriev...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, asvitki...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, zackha...@chromium.org, donnd...@chromium.org, filesapp...@chromium.org, gangwu...@chromium.org, jdeblas...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, android-web...@chromium.org, jatapiaro+wat...@google.com, browser-comp...@chromium.org, xinghui...@chromium.org, gogeral...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, fserb...@chromium.org, drott...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org
Attention needed from Patrick Monette

Matt Mueller voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Dec 2025 20:03:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
Dec 18, 2025, 5:48:19 PM (13 hours ago) Dec 18
to Matt Mueller, Chromium Metrics Reviews, Menard, Alexis, Mangesh Ghiware, Sophie Chang, Lei Zhang, Stephen Chenney, Mark Schillaci, Dirk Schulze, (Julie)Jeongeun Kim, Heron Yang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, vakh+safe_br...@chromium.org, drott+bl...@chromium.org, dullweb...@chromium.org, hanxi...@chromium.org, sloboda...@chromium.org, omnibox-...@chromium.org, dtseng...@chromium.org, ayman...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, twelling...@chromium.org, nwoked...@chromium.org, apavlo...@chromium.org, mattsimm...@chromium.org, vasilii+watchlis...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, christia...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org, yusufo...@chromium.org, fmalit...@chromium.org, derinel+wat...@google.com, yuzo+...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, devtools...@chromium.org, andysjl...@chromium.org, gcasto+w...@chromium.org, dewitt...@chromium.org, thegreenf...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, blink-reviews-p...@chromium.org, peilinwa...@google.com, blink-rev...@chromium.org, ender...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, language...@chromium.org, trewin...@google.com, penghuan...@chromium.org, extension...@chromium.org, lwinston+watc...@google.com, srahim...@chromium.org, josiah...@chromium.org, ios-revie...@chromium.org, mac-r...@chromium.org, dtapuska+...@chromium.org, blink-...@chromium.org, davidj...@chromium.org, yuezhang...@chromium.org, jmedle...@chromium.org, wychen...@chromium.org, blink-re...@chromium.org, agriev...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, asvitki...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, zackha...@chromium.org, donnd...@chromium.org, filesapp...@chromium.org, gangwu...@chromium.org, jdeblas...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, android-web...@chromium.org, jatapiaro+wat...@google.com, browser-comp...@chromium.org, xinghui...@chromium.org, gogeral...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, fserb...@chromium.org, drott...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Patrick Monette . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I487235195a8ac60f978d3fa34fb8198c806e3610
Gerrit-Change-Number: 7224452
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 22:48:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 18, 2025, 6:38:16 PM (13 hours ago) Dec 18
to Patrick Monette, Matt Mueller, Chromium Metrics Reviews, Menard, Alexis, Mangesh Ghiware, Sophie Chang, Lei Zhang, Stephen Chenney, Mark Schillaci, Dirk Schulze, (Julie)Jeongeun Kim, Akihiro Ota, Heron Yang, AyeAye, chromium...@chromium.org, webauthn...@chromium.org, vakh+safe_br...@chromium.org, drott+bl...@chromium.org, dullweb...@chromium.org, hanxi...@chromium.org, sloboda...@chromium.org, omnibox-...@chromium.org, dtseng...@chromium.org, ayman...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, twelling...@chromium.org, nwoked...@chromium.org, apavlo...@chromium.org, mattsimm...@chromium.org, vasilii+watchlis...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, christia...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, feature-me...@chromium.org, yusufo...@chromium.org, fmalit...@chromium.org, derinel+wat...@google.com, yuzo+...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, devtools...@chromium.org, andysjl...@chromium.org, gcasto+w...@chromium.org, dewitt...@chromium.org, thegreenf...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, blink-reviews-p...@chromium.org, peilinwa...@google.com, blink-rev...@chromium.org, ender...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, language...@chromium.org, trewin...@google.com, penghuan...@chromium.org, extension...@chromium.org, lwinston+watc...@google.com, srahim...@chromium.org, josiah...@chromium.org, ios-revie...@chromium.org, mac-r...@chromium.org, dtapuska+...@chromium.org, blink-...@chromium.org, davidj...@chromium.org, yuezhang...@chromium.org, jmedle...@chromium.org, wychen...@chromium.org, blink-re...@chromium.org, agriev...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, asvitki...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, zackha...@chromium.org, donnd...@chromium.org, filesapp...@chromium.org, gangwu...@chromium.org, jdeblas...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, chromium-a...@chromium.org, francisjp...@google.com, android-web...@chromium.org, jatapiaro+wat...@google.com, browser-comp...@chromium.org, xinghui...@chromium.org, gogeral...@chromium.org, abigailbk...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, fserb...@chromium.org, drott...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: net/ssl/ssl_client_session_cache_unittest.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Update SSLClientSessionCache to handle stateful memory pressure

Instead of reacting every time a memory pressure notification is sent,
each notification is treated as changing state, and repeat notifications
are no-op.

This is done by changing the cache's max size.
Bug: 465068849
Change-Id: I487235195a8ac60f978d3fa34fb8198c806e3610
Reviewed-by: Matt Mueller <ma...@chromium.org>
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560880}
Files:
  • M net/ssl/ssl_client_session_cache.cc
  • M net/ssl/ssl_client_session_cache.h
  • M net/ssl/ssl_client_session_cache_unittest.cc
Change size: M
Delta: 3 files changed, 74 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Matt Mueller
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I487235195a8ac60f978d3fa34fb8198c806e3610
Gerrit-Change-Number: 7224452
Gerrit-PatchSet: 12
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages