Share parsed CSS with @import across Declarative Shadow Roots [chromium/src : main]
0 views
Skip to first unread message
Helmut Januschka (Gerrit)
Apr 15, 2026, 6:06:59 PMApr 15
to Helmut Januschka, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Noam Rosenthal
Helmut Januschka added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Helmut Januschka . resolved
@nrose...@google.com thanks in advance for review, i left a few open discussions, where i would like to have either confirmation that it's ok, or a idea how to refactor/change.
really appreciate any help, please let me know if you want me to change anything.
File third_party/blink/renderer/core/css/parser/css_parser_impl.cc
Line 768, Patchset 7 (Latest):
if (!seen_rule && (rule || !base::FeatureList::IsEnabled(Helmut Januschka . unresolved
without the exception to accept failed parsing of @charset the provided samplers failed.
```
@charset "utf-8"; clg-profile-avatar {
display: inline-block;
height: var(--clg-avatar-host-size, var(--clg-dimension-app-avatar-base-size, 48px));
width: var(--clg-avatar-host-size, var(--clg-dimension-app-avatar-base-size, 48px))
}
```
--> https://www.etsy.com/ac/sasquatch/css/collage/shadow.f976e51d0fc8f2.css
never used @charset, not sure why this fails to parse.
File third_party/blink/renderer/core/css/style_sheet_contents.cc
Line 119, Patchset 5:
for (unsigned i = 0; i < import_rules_.size(); ++i) {Helmut Januschka . unresolved
Nit: This indexed loop intentionally follows the pattern used by the surrounding loops in this file. guess it could be better like:
```cpp
base::ranges::transform(o.import_rules_, import_rules_.begin(),
[this](const auto& rule) { return rule->CopyForShareableSheet(this); });
```
but guess that should be done as a follow up?
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Apr 16, 2026, 9:10:55 AM (14 days ago) Apr 16
to Helmut Januschka, Anders Hartvoll Ruud, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Anders Hartvoll Ruud and Helmut Januschka
Noam Rosenthal added 2 comments![]( "Open in Gerrit")
File third_party/blink/public/common/features.h
Line 252, Patchset 9 (Latest):
BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kCSSImportedStyleSheetCaching);Noam Rosenthal . unresolved
Make this a runtime_enabled_feature instead since it's blink only.
File third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.cc
Line 236, Patchset 9 (Latest):
SetParsedStyleSheetCache(nullptr);Noam Rosenthal . unresolved
If this can only happen with the new flag, CHECK here for the flag being enabled.
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Apr 16, 2026, 3:38:57 PM (14 days ago) Apr 16
to Helmut Januschka, Anders Hartvoll Ruud, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Anders Hartvoll Ruud and Noam Rosenthal
Helmut Januschka added 2 comments![]( "Open in Gerrit")
File third_party/blink/public/common/features.h
Line 252, Patchset 9 (Latest):
BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kCSSImportedStyleSheetCaching);Noam Rosenthal . resolved
Make this a runtime_enabled_feature instead since it's blink only.
Helmut Januschka
Done
File third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.cc
Line 236, Patchset 9 (Latest):
SetParsedStyleSheetCache(nullptr);Noam Rosenthal . resolved
If this can only happen with the new flag, CHECK here for the flag being enabled.
Attention is currently required from:
- Anders Hartvoll Ruud
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Apr 17, 2026, 7:01:12 AM (13 days ago) Apr 17
to Helmut Januschka, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Helmut Januschka and Noam Rosenthal
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Anders Hartvoll Ruud . unresolved
Sharing of StyleSheetContents has been a recurring source of bugs, some _extremely_ subtle and elusive, so any change in this area needs to be completely bulletproof.
As it stands now, and absent any explanation/plan/description, I struggle to see the cohesion and reasoning between the various changes in this CL.
Related details
Attention is currently required from:
- Helmut Januschka
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages