[Blink] Eliminate CanvasRCHost::GetOrCreateCRP2D() [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Jun 23, 2025, 11:51:57 AM6/23/25

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2025, 2:35:14 AM6/24/25

to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Blink] Eliminate CanvasRCHost::GetOrCreateCRP2D()

Inline it in its only caller in HTMLCanvasElement.

Bug: 352263194

Change-Id: I674abd29b6ad30479265016eb22dd7548ea2b9e9

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6662358

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1477738}

Files:

M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc

Change size: M

Delta: 5 files changed, 20 insertions(+), 32 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages