[heap] Record GrowingMode in GC Cycle UKM [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jun 18, 2026, 12:58:59 PMJun 18
to Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 19, 2026, 5:46:33 AM (14 days ago) Jun 19
to Etienne Pierre-Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Etienne Pierre-Doray
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 19, 2026, 7:02:00 AM (14 days ago) Jun 19
to Robert Kaplow, Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Robert Kaplow
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Kaplow (Gerrit)
Jun 19, 2026, 1:41:56 PM (14 days ago) Jun 19
to Etienne Pierre-Doray, Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Etienne Pierre-Doray
Robert Kaplow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 19, 2026, 2:13:51 PM (14 days ago) Jun 19
to Robert Kaplow, Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 19, 2026, 3:08:23 PM (14 days ago) Jun 19
to Etienne Pierre-Doray, Robert Kaplow, Michael Lippautz, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Record GrowingMode in GC Cycle UKM
Growing mode informs on heap limit heuristics.
Following https://chromium-review.git.corp.google.com/c/v8/v8/+/7957808
Bug: 477484620
Change-Id: Ie5da39bf7ca048939660a616ee9d07fbecd521c0
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649766}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_metrics.cc
- M tools/metrics/histograms/metadata/v8/enums.xml
- M tools/metrics/ukm/ukm.xml
Change size: S
Delta: 3 files changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Robert Kaplow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jun 19, 2026, 7:45:00 PM (13 days ago) Jun 19
to Chromium LUCI CQ, Etienne Pierre-Doray, Robert Kaplow, Michael Lippautz, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jun 21, 2026, 8:13:46 PM (11 days ago) Jun 21
to Chromium LUCI CQ, Etienne Pierre-Doray, Robert Kaplow, Michael Lippautz, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Etienne Pierre-Doray
Takashi Sakamoto added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/v8_metrics.cc
Line 470, Patchset 4 (Latest):
.SetGrowingMode(event.growing_mode)Takashi Sakamoto . unresolved
I'm not sure, but...this looks...
```
v8::metrics::GarbageCollectionFullCycle event;
event.reason = static_cast<int>(current_.gc_reason);
event.incremental_marking_reason =
static_cast<int>(current_.incremental_marking_reason);
event.growing_mode = static_cast<int>(current_.growing_mode); // current_.growing_mode is sometimes uninitialized?
event.priority = current_.priority;
event.reduce_memory = current_.reduce_memory;
```
(v8/src/heap/gc-tracer.cc)
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages