Migrate fetch-related partial interface to partial interface mixin [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Oct 3, 2025, 11:54:43 AM (3 days ago) Oct 3
to Nidhi Jaju, Jinho Bang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Nidhi Jaju

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Suyeon Ji . resolved

Hi! Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Nidhi Jaju
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5f39dfbb71ff57d171c7d18e94bf77bd6017c4f4
Gerrit-Change-Number: 7004735
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinho Bang (Gerrit)

unread,
Oct 3, 2025, 12:32:43 PM (3 days ago) Oct 3
to Suyeon Ji, Nidhi Jaju, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Nidhi Jaju and Suyeon Ji

Jinho Bang voted and added 1 comment

Votes added by Jinho Bang

Code-Review+1

1 comment

Patchset-level comments
Jinho Bang . resolved

non-owner lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Nidhi Jaju
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5f39dfbb71ff57d171c7d18e94bf77bd6017c4f4
Gerrit-Change-Number: 7004735
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 16:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nidhi Jaju (Gerrit)

unread,
Oct 5, 2025, 9:55:39 PM (4 hours ago) Oct 5
to Suyeon Ji, Jinho Bang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Nidhi Jaju voted and added 2 comments

Votes added by Nidhi Jaju

Code-Review+1

2 comments

Patchset-level comments
Nidhi Jaju . resolved

lgtm, thanks!

File third_party/blink/renderer/core/fetch/window_or_worker_global_scope_fetch.idl
Line 1, Patchset 2 (Latest):// Copyright 2015 The Chromium Authors
Nidhi Jaju . unresolved

Did you mean to change the year to 2025?
```suggestion
// Copyright 2025 The Chromium Authors
```

Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5f39dfbb71ff57d171c7d18e94bf77bd6017c4f4
Gerrit-Change-Number: 7004735
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 01:55:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Suyeon Ji (Gerrit)

unread,
12:45 AM (1 hour ago) 12:45 AM
to Nidhi Jaju, Jinho Bang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Nidhi Jaju

Suyeon Ji added 1 comment

File third_party/blink/renderer/core/fetch/window_or_worker_global_scope_fetch.idl
Line 1, Patchset 2:// Copyright 2015 The Chromium Authors
Nidhi Jaju . resolved

Did you mean to change the year to 2025?
```suggestion
// Copyright 2025 The Chromium Authors
```

Suyeon Ji

Oops, I meant to update it to 2025 but made a mistake.
I thought it was a new file, but it was a rename, so I reverted it.
Thank you for review.

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Nidhi Jaju
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5f39dfbb71ff57d171c7d18e94bf77bd6017c4f4
    Gerrit-Change-Number: 7004735
    Gerrit-PatchSet: 3
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Jinho Bang <zi...@chromium.org>
    Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Oct 2025 04:44:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Nidhi Jaju <nidh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages